tmplimpl: Add support for ellipsed paginator #3472
Conversation
|
The paginator in its various stages examplified:
|
|
See it in action here: http://bepsays.com/side/7/ |
| {{ end }} | ||
| {{ if $showNumber }} | ||
| <li | ||
| {{ if eq . $pag }}class="active"{{ end }}><a href="{{ .URL }}">{{ .PageNumber }}</a></li> |
| {{ end }} | ||
| <li | ||
| {{ if not $pag.HasPrev }}class="disabled"{{ end }}> | ||
| <a href="{{ if $pag.HasPrev }}{{ $pag.Prev.URL }}{{ end }}" aria-label="Previous"><span aria-hidden="true">«</span></a> |
There was a problem hiding this comment.
This is a tricky accessibility issue: do we keep "Previous" if it means including English assistive text in multilingual sites?
If yes, we should likely add aria-label's to each of the anchors; e.g. aria-label="Go to Page {{.PageNumber}}".
If this is in any way a breaking change, however, I'm not too adamant about it.
There was a problem hiding this comment.
Hearing from the blind person in the forum, I think we overvalue the labels. I suspect that it gets noisy when doing too much. If a blind person "sees" a sequence of integer links, he/she understands that it is a paginator.
And in general, your remarks are about the existing code. This PR should focus on the changes made.
There was a problem hiding this comment.
I think we overvalue the labels. I suspect that it gets noisy when doing too much. If a blind person "sees" a sequence of integer links, he/she understands that it is a paginator.
I wouldn't presume to know; hence why I defer to standards built for AT.
And...
...I'm not too adamant about it
LGTM 👍
There was a problem hiding this comment.
We can look at this later ... would nice if you could post a link to those standards? (but I suspect those standards are written by people who see)
There was a problem hiding this comment.
...would nice if you could post a link to those standards?
Sure:
- AT screen readers and
aria-current(Video) (Note this also shows tab indexing andaria-label). - w3's
aria-current, spec (Note section on pagination andpagetoken) - Accessible pagination (A11Y)
but I suspect those standards are written by people who see
I agree we can table these as maybe "future iterative improvements?"
| {{ end }} | ||
| </ul> | ||
| {{ end }}`) | ||
| {{ if gt $pag.TotalPages 1 }} |
There was a problem hiding this comment.
My assumption is that this would be a breaking change, but really this needs to be wrapped in <nav role="navigation" aria-label="Pagination Navigation">. Only mentioning this here as a note that I should add this to the new docs.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #3466