Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpl/tplimpl: Add .Site.Title to embedded opengraph template #8991

Closed
wants to merge 2 commits into from

Conversation

sean-au
Copy link

@sean-au sean-au commented Sep 24, 2021

Added .Site.Title, to go alongside the existing .Site.Params.Title lookup for og:site_name.

.Site.Title has been given preference.

.Site.Title is specified in the hugo docs as the place to record the sites name https://gohugo.io/getting-started/configuration/#title

Its also configured by default when running "hugo new site"

# config.toml
baseURL = "http://example.org/"
languageCode = "en-us"
title = "My New Hugo Site"

@bep
Copy link
Member

bep commented Oct 10, 2021

This looks good, but could you run mage generate to rebuild the template "cache".

@sean-au
Copy link
Author

sean-au commented Oct 11, 2021

That should work

@jmooring jmooring requested a review from bep November 1, 2021 20:01
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


sean-pwd seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jmooring jmooring changed the title added .Site.Title option tpl/tplimpl: Add .Site.Title to embedded opengraph template May 4, 2023
jmooring added a commit to jmooring/hugo that referenced this pull request Apr 1, 2024
Changes:

- Add tags per documentation
- Prefer site.Title over site.Params.title
- Plainify titles, tags, and descriptions
- Add fallback values for locale
- Fix pages related by series
- Improve readability

Closes gohugoio#8296
Closes gohugoio#8698
Closes gohugoio#8991
Closes gohugoio#9818
Closes gohugoio#9866
Closes gohugoio#10647

Co-authored by: tomy0000000 <[email protected]>
Co-authored by: sean-au <[email protected]>
jmooring added a commit to jmooring/hugo that referenced this pull request Apr 1, 2024
Changes:

- Add tags per documentation
- Prefer site.Title over site.Params.title
- Plainify titles, tags, and descriptions
- Add fallback values for locale
- Fix pages related by series
- Improve readability

Closes gohugoio#8296
Closes gohugoio#8698
Closes gohugoio#8991
Closes gohugoio#9818
Closes gohugoio#9866
Closes gohugoio#10647

Co-authored-by: tomy0000000 <[email protected]>
Co-authored-by: sean-au <[email protected]>
jmooring added a commit to jmooring/hugo that referenced this pull request Apr 2, 2024
Changes:

- Add tags per documentation
- Prefer site.Title over site.Params.title
- Plainify titles, tags, and descriptions
- Add fallback values for locale
- Fix pages related by series
- Improve readability

Closes gohugoio#8296
Closes gohugoio#8698
Closes gohugoio#8991
Closes gohugoio#9818
Closes gohugoio#9866
Closes gohugoio#10647

Co-authored-by: tomy0000000 <[email protected]>
Co-authored-by: sean-au <[email protected]>
jmooring added a commit to jmooring/hugo that referenced this pull request Apr 2, 2024
Changes:

- Add tags per documentation
- Prefer site.Title over site.Params.title
- Plainify titles, tags, and descriptions
- Add fallback values for locale
- Fix pages related by series
- Improve readability

Closes gohugoio#8296
Closes gohugoio#8698
Closes gohugoio#8991
Closes gohugoio#9818
Closes gohugoio#9866
Closes gohugoio#10647

Co-authored-by: tomy0000000 <[email protected]>
Co-authored-by: sean-au <[email protected]>
@bep bep closed this in #12328 Apr 2, 2024
@bep bep closed this in 2da4ec5 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants