-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tpl/tplimpl: Add .Site.Title to embedded opengraph template #8991
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks good, but could you run |
That should work |
sean-pwd seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
jmooring
changed the title
added .Site.Title option
tpl/tplimpl: Add .Site.Title to embedded opengraph template
May 4, 2023
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 1, 2024
Changes: - Add tags per documentation - Prefer site.Title over site.Params.title - Plainify titles, tags, and descriptions - Add fallback values for locale - Fix pages related by series - Improve readability Closes gohugoio#8296 Closes gohugoio#8698 Closes gohugoio#8991 Closes gohugoio#9818 Closes gohugoio#9866 Closes gohugoio#10647 Co-authored by: tomy0000000 <[email protected]> Co-authored by: sean-au <[email protected]>
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 1, 2024
Changes: - Add tags per documentation - Prefer site.Title over site.Params.title - Plainify titles, tags, and descriptions - Add fallback values for locale - Fix pages related by series - Improve readability Closes gohugoio#8296 Closes gohugoio#8698 Closes gohugoio#8991 Closes gohugoio#9818 Closes gohugoio#9866 Closes gohugoio#10647 Co-authored-by: tomy0000000 <[email protected]> Co-authored-by: sean-au <[email protected]>
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 2, 2024
Changes: - Add tags per documentation - Prefer site.Title over site.Params.title - Plainify titles, tags, and descriptions - Add fallback values for locale - Fix pages related by series - Improve readability Closes gohugoio#8296 Closes gohugoio#8698 Closes gohugoio#8991 Closes gohugoio#9818 Closes gohugoio#9866 Closes gohugoio#10647 Co-authored-by: tomy0000000 <[email protected]> Co-authored-by: sean-au <[email protected]>
jmooring
added a commit
to jmooring/hugo
that referenced
this pull request
Apr 2, 2024
Changes: - Add tags per documentation - Prefer site.Title over site.Params.title - Plainify titles, tags, and descriptions - Add fallback values for locale - Fix pages related by series - Improve readability Closes gohugoio#8296 Closes gohugoio#8698 Closes gohugoio#8991 Closes gohugoio#9818 Closes gohugoio#9866 Closes gohugoio#10647 Co-authored-by: tomy0000000 <[email protected]> Co-authored-by: sean-au <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added .Site.Title, to go alongside the existing .Site.Params.Title lookup for og:site_name.
.Site.Title has been given preference.
.Site.Title is specified in the hugo docs as the place to record the sites name https://gohugo.io/getting-started/configuration/#title
Its also configured by default when running "hugo new site"