Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature sensor email trigger #1

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Feature sensor email trigger #1

wants to merge 31 commits into from

Conversation

gokulav137
Copy link
Owner

Checklist:

@gokulav137 gokulav137 marked this pull request as ready for review September 9, 2023 11:52
dependabot bot and others added 20 commits September 9, 2023 19:19
@dependabot @gokulav137
chore(deps): bump github.com/antonmedv/expr from 1.14.3 to 1.15.0 (ar…
136dbe2 
…goproj#2781)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Add EmailTrigger Type
eb38cea 
Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Add EmailTrigger which impliments Trigger interface
0bdf464 
    - EmailTrigger use EmailService to send email
    - Execute asserts receiver email is provided
    - Execute asserts receiver emails are valid emails
    - Execute asserts Body cannot be empty
    - Execute asserts Subject cannot be empty

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Add EmailTrigger to GetTrigger
c785f15 
Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Fix Protobuf Errors
e440c25 
- Change Port from int to int32
- Fix typo portobuf to protobuf
- Change protobuf type for port from bytes to varint
- Fix typo protobuff to protobuf

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Make codegen
147bd97 
Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Fix type error - Cast emaiTrigger.Port int32 to int
296311b 
Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Move email trigger validation from sensor/trigger/email/email.go to c…
afaf548 
…ontrollers/sensor/validate.go

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Modify To email address from list of string to string with one email …
cb1aa75 
…address

Change is made as notification.emailService doesnot support multiple to
email addresses

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Refactor EmailTrigger type - Reorder for readability, bring smtp
5ff643c 
username and password together

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Modify EmailTrigger To,From,Subject and Body to be optional
3a8ca4d 
- Add optional comment to EmailTrigger type
- Move validation for To,From,Subject and Body from
	controller validation to trigger execution validation

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Add optional and default comment to Port for EmailTrigger type
1be6e5d 
EmailTrigger Port default value specified as 0

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Add EmailTrigger Username, Host, Port validation to Sensor Validation
a3ac2ba 
- Username can't be empty
- Host can't be empty
- Port should be between 0-65535

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Add unit tests for email package - sensors/triggers/email
266e96b 
- Test EmailTrigger.FetchResource
- Test EmailTrigger.ApplyResource
- Test EmailTrigger.Execute

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Add Example for EmailTrigger
5c5a6c1 
Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Add formatting for EmailTrigger in types - add full stop
ea3ec14 
Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Run make codegen
fee3853 
Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Refactor tests to not use variable defined outside Run
f722bcf 
Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Fix linting errors
c5bc890 
Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Run make codegen - after downgrading pandoc to 2.17.1
bd49ef9 
Signed-off-by: gokulav137 <[email protected]>
@gokulav137 gokulav137 force-pushed the feature-sensor-email-trigger branch from 4e85cd9 to bd49ef9 Compare September 9, 2023 13:52
gokulav137 and others added 8 commits September 9, 2023 19:49
@gokulav137
Merge branch 'master' into feature-sensor-email-trigger
a153daf
@gokulav137
Modify EmailTrigger to support multiple to email addresses
31d9056 
- Modified EmailTrigger.To from string to []string
- Refactored email sending logic to send an email each to all the
	addresses in To

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Modified EmailTriger example to use list for To and reduced example c…
bbb1f45 
…omplexity

Removed parameterization to reduce complexity in example

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Add support for smtp servers without authentication
115668e 
- Modify types comment for Username and SMTPPassword to be optional
- Remove Username and SMTPPassword requirement check
- Refactor SMTPPassword retrieval from secrets to only when SMTPPassword is
	not nil

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Run Make codegen
9620178 
Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Modify example for documentation
dbfc55c 
- Add dynamic to email use case and commented satic to email use case

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Fix typo in example DataTemplate -> dataTemplate
37a460f 
Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Add Doc for Email Trigger
2858e03 
Signed-off-by: gokulav137 <[email protected]>
gokulav137 and others added 3 commits September 16, 2023 14:12
@gokulav137
Merge branch 'master' into feature-sensor-email-trigger
33b73ec
@gokulav137
Refactor connection maps for trigger clients from map to concurrent s…
d0d4870 
…afe maps

- HTTP client
- CustomTrigger client
- Kafka client
- Pulsar client
- NATS client
- Lambda client
- OpenWhisk client
- Eventbus client
- Servicebus client

Signed-off-by: gokulav137 <[email protected]>
@gokulav137
Merge branch 'feature-sensor-email-trigger' of https://github.com/gok…
321c62d 
…ulav137/argo-events into feature-sensor-email-trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gokulav137