Postgres: Add a check to determine if table already exists to elide CREATE query #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testtest959
force-pushed
the
modify-ensure-version-table
branch
from
c8e03d2 to
5864780
Compare
testtest959
force-pushed
the
modify-ensure-version-table
branch
from
8e5aca6 to
9d00b4b
Compare
Pull Request Test Coverage Report for Build 247
💛 - Coveralls |
dhui
requested changes
Mar 17, 2021
database/postgres/postgres_test.go
Outdated
|
|
||
| // create user who is not the owner. Although we're concatenating strings in an sql statement it should be fine | ||
| // since this is a test environment and we're not expecting to the pgPassword to be malicious | ||
| if err := d.Run(strings.NewReader("CREATE USER not_owner WITH ENCRYPTED PASSWORD '" + pgPassword + "'")); err != nil { |
There was a problem hiding this comment.
Looks like there are a bunch of setup statements for these tests. Create a mustRun(testing.T*, []string) method and use that.
There was a problem hiding this comment.
Awesome! That makes this a lot cleaner
|
|
||
| var e *database.Error | ||
| if !errors.As(err, &e) || err == nil { | ||
| t.Fatal("Unexpected error, want permission denied error. Got: ", err) |
There was a problem hiding this comment.
Is the permission denied error exposed? e.g. a postgres error code
There was a problem hiding this comment.
Yup, but we have to parse the error string to do it. Made the change!
testtest959
force-pushed
the
modify-ensure-version-table
branch
from
7ea2991 to
9788837
Compare
dhui
reviewed
Mar 18, 2021
database/pgx/pgx_test.go
Outdated
| t.Fatal("Unexpected error, want permission denied error. Got: ", err) | ||
| } | ||
|
|
||
| if strings.Contains(e.Err, "permission denied for schema barfoo") { |
There was a problem hiding this comment.
Shouldn't this be !strings.Contains()?
There was a problem hiding this comment.
Nice catch, the assert was broken before then
database/postgres/postgres_test.go
Outdated
| t.Fatal("Unexpected error, want permission denied error. Got: ", err) | ||
| } | ||
|
|
||
| if strings.Contains(e.Err, "permission denied for schema barfoo") { |
dhui
approved these changes
Mar 19, 2021
stephane-klein
pushed a commit
to spacefill/migrate
that referenced
this pull request
Apr 4, 2021
…REATE query (golang-migrate#526) * Squash commits * Format * Minor refactoring * Address PR feedback; Add mustRun * Fix a test assert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check in
ensureVersionTable()in order to prevent a CREATE query which may fail for read only users. As a result, read only users will be able to query the schema version.Closes #266