Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for modernc.org/sqlite #555

Merged
merged 2 commits into from
May 5, 2021
Merged

Add support for modernc.org/sqlite #555

merged 2 commits into from
May 5, 2021

Conversation

gammazero
Copy link
Contributor

This PR adds support for the CGo-free port of SQLite.

Reference issue #59

This is a CGo-free port of SQLite
@coveralls
Copy link

coveralls commented Apr 30, 2021

Pull Request Test Coverage Report for Build 344

  • 119 of 179 (66.48%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 57.409%

Changes Missing Coverage Covered Lines Changed/Added Lines %
database/sqlite/sqlite.go 119 179 66.48%
Totals Coverage Status
Change from base Build 327: 0.3%
Covered Lines: 3607
Relevant Lines: 6283

💛 - Coveralls

Copy link
Member

@dhui dhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's limited support for OS and arches: https://pkg.go.dev/modernc.org/sqlite#hdr-Changelog

How has compatibility with sqlite been ensured/tested with this db driver?

I don't think we can replace the old sqlite db driver with this one yet, but we can add it as a new one, similar to how we support both pgx and pq.

@gammazero
Copy link
Contributor Author

@dhui Yes, OS/arch support is currently limited, so I have removed sqlite from the DATABASE build target in the Makefile. This makes its support equivalent to how sqlite3 is supported. Users can build the GUI with support for sqlite if needed, but support is not built by default and is not included in the binary distribution.

I think that go-migrate should support both sqlite and sqlite3 as both are popular packages, and this PR does not intend to replace sqlite3, but offer sqlite support in addition.

This PR is basically a copy of the database/sqlite3 package, but using the modernc.org sqlite instead.

@dhui dhui merged commit 512097b into golang-migrate:master May 5, 2021
@dhui
Copy link
Member

dhui commented Dec 18, 2021

Here's an updated link of supported OSes and Arches: https://pkg.go.dev/modernc.org/sqlite#hdr-Supported_platforms_and_architectures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants