-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support clickhouse cluster #568
Adding support clickhouse cluster #568
Conversation
05f32e8
to
24cd4c7
Compare
Pull Request Test Coverage Report for Build 1159872900
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my future reference: clickhouse distributed ddl docs
Overall, this change LGTM. Keep in mind that you may have issues if migrations are run simultaneously on different machines since the clickhouse db driver doesn't use a distributed lock.
Can you add tests or is it not possible to setup a cluster in docker?
Signed-off-by: Ildar Valiullin <[email protected]>
f9df314
to
4e2ae5b
Compare
@dhui, for me its look like too hard. I viewed realized tests in project and can't imagine how to do that in such flow. For replicate tables over clickhouse nodes, we have to up 2 or more clickhouse nodes with customized config file(need zookeeper instance address specify). dktest, if I undestand correct, do not allow to mount volumes into declared containers. So, should I create very custom test for this case? |
Yeah, I don't think it's a trivial amount of work to run multiple containers & images on the same network so we can test a clickhouse cluster setup. I'd love to have integration tests for clickhouse clusters, but if it's not feasible, we can add a caveat in the docs stating that clickhouse clusters aren't officially supported since there aren't any tests. |
Signed-off-by: Ildar Valiullin <[email protected]>
4e2ae5b
to
d312b4c
Compare
@dhui, I added notes in README.md. Did you mean it? |
@dhui, so can it be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay and thanks again for the PR!
Hello. I would like to create cluster wide
schema_migrations
table, when I run migrations on clusterized clickhouse. As I think, It's will guarante that new migrations may be executed on any node of cluster.