Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memcache item timestamps #323

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

Deleplace
Copy link
Contributor

Hi, these changes reflect new capabilities of App Engine's memcache mostly related to the Last Access timestamp of an item.

Similar changes are being made to the Java client lib, but the Go lib ignores the concept of item "delete lock".

@Deleplace
Copy link
Contributor Author

See also some tests in repo https://github.com/Deleplace/memcache-new-fields

@ludoch ludoch requested a review from jinglundong August 24, 2023 18:24
@jinglundong jinglundong requested a review from kennethye1 August 24, 2023 19:33
memcache/memcache.go Outdated Show resolved Hide resolved
memcache/memcache.go Outdated Show resolved Hide resolved
v2/memcache/memcache.go Outdated Show resolved Hide resolved
v2/memcache/memcache.go Outdated Show resolved Hide resolved
@Deleplace Deleplace requested a review from kennethye1 August 25, 2023 07:25
@Deleplace
Copy link
Contributor Author

Applied minor changes (use getters) thanks to Kenneth's review.

Copy link
Collaborator

@kennethye1 kennethye1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennethye1 kennethye1 merged commit ef2135a into golang:master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants