Skip to content

Commit

Permalink
cmd/release: notify explorer of PATH update after install on Win
Browse files Browse the repository at this point in the history
Windows installer will not broadcast WM_SETTINGCHANGE when a reboot is
pending. This message is required for explorer.exe to reload the PATH
from the registry so future cmd.exe processes will launch with go/bin in
the PATH.

Use the Wix extension to always broadcast this message after install.

More info:
http://wixtoolset.org/documentation/manual/v3/customactions/wixsettingchange.html

Fixes golang/go#18680

Change-Id: I4f3af49f167f3875bbf8e898f4d50ee358b4e35d
Reviewed-on: https://go-review.googlesource.com/36324
Reviewed-by: Chris Broadfoot <[email protected]>
  • Loading branch information
johnsonj authored and broady committed Feb 7, 2017
1 parent 0979e53 commit 924bb6b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions cmd/release/releaselet.go
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,9 @@ var windowsData = map[string]string{
<Custom Action="SetApplicationRootDirectory" Before="InstallFinalize" />
</InstallExecuteSequence>
<!-- Notify top level applications of the new PATH variable (golang.org/issue/18680) -->
<CustomActionRef Id="WixBroadcastEnvironmentChange" />
<!-- Include the user interface -->
<WixVariable Id="WixUILicenseRtf" Value="LICENSE.rtf" />
<WixVariable Id="WixUIBannerBmp" Value="images\Banner.jpg" />
Expand Down

0 comments on commit 924bb6b

Please sign in to comment.