Skip to content

Commit

Permalink
runtime: remove linkname from memhash{32,64} functions
Browse files Browse the repository at this point in the history
github.com/parquet-go/parquet-go was listed as the only user of these
functions. parquet-go/parquet-go#142 removes the
linkname dependency on these functions, so the linkname directive can now be
removed.
  • Loading branch information
asubiotto committed Jun 3, 2024
1 parent 45aa0a5 commit e14c4e4
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions src/runtime/alg.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ var useAeshash bool
// - github.com/outcaste-io/ristretto
// - github.com/puzpuzpuz/xsync/v2
// - github.com/puzpuzpuz/xsync/v3
// - github.com/parquet-go/parquet-go
// - github.com/authzed/spicedb
// - github.com/pingcap/badger
//
Expand All @@ -66,26 +65,8 @@ var useAeshash bool
//go:linkname memhash
func memhash(p unsafe.Pointer, h, s uintptr) uintptr

// memhash32 should be an internal detail,
// but widely used packages access it using linkname.
// Notable members of the hall of shame include:
// - github.com/parquet-go/parquet-go
//
// Do not remove or change the type signature.
// See go.dev/issue/67401.
//
//go:linkname memhash32
func memhash32(p unsafe.Pointer, h uintptr) uintptr

// memhash64 should be an internal detail,
// but widely used packages access it using linkname.
// Notable members of the hall of shame include:
// - github.com/parquet-go/parquet-go
//
// Do not remove or change the type signature.
// See go.dev/issue/67401.
//
//go:linkname memhash64
func memhash64(p unsafe.Pointer, h uintptr) uintptr

// strhash should be an internal detail,
Expand Down

0 comments on commit e14c4e4

Please sign in to comment.