Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: multi-arch build via qemu fails to exec go binary [1.23 backport] #68995

Closed
gopherbot opened this issue Aug 21, 2024 · 3 comments
Closed

cmd/go: multi-arch build via qemu fails to exec go binary [1.23 backport] #68995

gopherbot opened this issue Aug 21, 2024 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. GoCommand cmd/go telemetry x/telemetry issues
Milestone
Go1.23.1

Comments

@gopherbot
Copy link
Contributor

@findleyr requested issue #68976 to be considered for backport to the next 1.23 minor release.

Thanks again @dmitshur.

@gopherbot please backport this issue to 1.23: it is a regression that breaks the go command in certain environments.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 21, 2024
@gopherbot gopherbot mentioned this issue Aug 21, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 21, 2024
@gopherbot gopherbot added this to the Go1.23.1 milestone Aug 21, 2024
@findleyr findleyr added the telemetry x/telemetry issues label Aug 27, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/609136 mentions this issue: [internal-branch.go1.23-vendor] telemetry: do not crash parent if child could not be started

@prattmic prattmic added the GoCommand cmd/go label Aug 28, 2024
@prattmic prattmic changed the title syscall: multi-arch build via qemu fails to exec go binary [1.23 backport] cmd/gp: multi-arch build via qemu fails to exec go binary [1.23 backport] Aug 28, 2024
@prattmic prattmic changed the title cmd/gp: multi-arch build via qemu fails to exec go binary [1.23 backport] cmd/go: multi-arch build via qemu fails to exec go binary [1.23 backport] Aug 28, 2024
@prattmic prattmic added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Aug 28, 2024
gopherbot pushed a commit to golang/telemetry that referenced this issue Aug 28, 2024
@matloob @prattmic
[internal-branch.go1.23-vendor] telemetry: do not crash parent if chi…
40b6b7f 
…ld could not be started

Instead of calling log.Fatal if the child could not be started, call
log.Print. Various factors in the user's environment could cause the
child to not be able to start, but that shouldn't crash the parent
process (usually the go command).

Change other fatals into prints with early returns when attempting to
start the child.

Reset the crash output file to clean up if the child process could not
be started and crashmonitoring is enabled.

Updates golang/go#68976
Updates golang/go#68995

Change-Id: I42f55dc90f68f91b272a7ebf64d2a4a3b00815c7
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/607595
Commit-Queue: Michael Matloob <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
(cherry picked from commit 61baa7d)
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/609136
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/609355 mentions this issue: [release-branch.go1.23] cmd: vendor golang.org/x/[email protected]

gopherbot pushed a commit that referenced this issue Aug 29, 2024
@prattmic @gopherbot
[release-branch.go1.23] cmd: vendor golang.org/x/telemetry@internal-b…
3d1f1f2 
…ranch.go1.23-vendor

Update x/telemetry to fix #68976 and #68946.

Commands run:
  go get golang.org/x/[email protected]
  go mod tidy
  go mod vendor

Fixes #68994.
Fixes #68995.

Change-Id: I63b892ad4c313aa92f21fbd4f519a0b19d725849
Reviewed-on: https://go-review.googlesource.com/c/go/+/609355
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Michael Pratt <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
@gopherbot
Copy link
Contributor Author

Closed by merging CL 609355 (commit 3d1f1f2) to release-branch.go1.23.

@prattmic prattmic mentioned this issue Sep 4, 2024
Closed
@iPraveenParihar iPraveenParihar mentioned this issue Jan 2, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. GoCommand cmd/go telemetry x/telemetry issues
Projects
None yet
Milestone
Go1.23.1
Development

No branches or pull requests
3 participants
@prattmic @gopherbot @findleyr