-
Notifications
You must be signed in to change notification settings - Fork 606
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks for your contribution, I like the idea of this change. I am just thinking wether something like this should be put behind a verbose flag... Thinking... |
@cvgw @nguyenfilip What are your thoughts on this? Should something like this be default behavior, or should we hide types behind the verbose flag?!? |
@codyoss my initial thought is that I would want the type info returned when needed without having to enable a flag. What would "when needed" mean? Perhaps an initial check whether the types are equal before evaluating further? That way an error message specific to the type could be generated and the rest of the error messages could exclude type information. Looking at the current code I think that would be a non-trivial effort and would require some refactoring of where error messages are generated. |
I like that idea. Also I agree, it would be a non-trivial effort. |
I am going to close this for now as I think we need a more robust solution. I think this is still an issue and something we need to work towards. |
Referring to this issue.
Add data type on error message if the data type is not equal