Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

Make error message clearer #341

Closed
wants to merge 1 commit into from

Conversation

adzimzf
Copy link

@adzimzf adzimzf commented Nov 3, 2019

Referring to this issue.
Add data type on error message if the data type is not equal

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@adzimzf
Copy link
Author

adzimzf commented Nov 3, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@codyoss codyoss self-assigned this Nov 20, 2019
@codyoss
Copy link
Member

codyoss commented Nov 27, 2019

Thanks for your contribution, I like the idea of this change. I am just thinking wether something like this should be put behind a verbose flag... Thinking...

@codyoss
Copy link
Member

codyoss commented Dec 27, 2019

@cvgw @nguyenfilip What are your thoughts on this? Should something like this be default behavior, or should we hide types behind the verbose flag?!?

@cvgw
Copy link
Collaborator

cvgw commented Dec 27, 2019

@codyoss my initial thought is that I would want the type info returned when needed without having to enable a flag. What would "when needed" mean? Perhaps an initial check whether the types are equal before evaluating further? That way an error message specific to the type could be generated and the rest of the error messages could exclude type information.

Looking at the current code I think that would be a non-trivial effort and would require some refactoring of where error messages are generated.

@codyoss
Copy link
Member

codyoss commented Dec 27, 2019

I like that idea. Also I agree, it would be a non-trivial effort.

@codyoss
Copy link
Member

codyoss commented Feb 28, 2020

I am going to close this for now as I think we need a more robust solution. I think this is still an issue and something we need to work towards.

@codyoss codyoss closed this Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants