jsonpb: fix unmarshaling JSON object with escaped string into Struct type #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cybrcodr
commented
May 18, 2018
jsonpb/jsonpb_test.go
Outdated
| {"StructValue containing StringValue's", Unmarshaler{}, "{\"escaped\": \"a\\/b\", \"unicode\": \"\\u00004E16\\u0000754C\"}", | ||
| &stpb.Struct{ | ||
| Fields: map[string]*stpb.Value{ | ||
| "escaped": {Kind: &stpb.Value_StringValue{"a/b"}}, |
There was a problem hiding this comment.
This testcase exposes issue #605.
Note that the other testcases that I added here are somehow working even before adding the fix in.
test on StringValue.
cybrcodr
commented
May 18, 2018
dsnet
approved these changes
May 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix unmarshaling JSON object with escaped string into Struct type.
Fixes #605