jsonpb: error on scalar enum provided for repeated enums instead of panic #627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue where attempting to unmarshal valid json that contains a field with a single enum into a message that has a repeated enum field causes a panic. For example, try to unmarshal this:
into a message that looks like this:
This will cause a panic. I know the json is an invalid representation of the Message struct, but it shouldn't panic. I'm attempting to fix this issue by validating that the targetType is correct before setting the enum.