-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unix: fix MremapPtr test failing on NetBSD #198
Conversation
This PR (HEAD: 7219003) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/594756. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
NetBSD apparently doesn't allow remapping into used address space. This means that the test that uses mremap to move a mmapped page into a new address should first mmap (to reserve) then munmap (to free) the destination. Fixes golang/go#68180 Change-Id: If66b67e7166ca4dc4331a8cfc3e3a285416e9849 GitHub-Last-Rev: 7219003 GitHub-Pull-Request: #198 Cq-Include-Trybots: luci.golang.try:go1.23-netbsd-amd64
This PR (HEAD: 92058c2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/594756. Important tips:
|
Message from Nuno Cruces: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Ian Lance Taylor: Patch Set 5: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-26T00:43:43Z","revision":"b1254df4909bff17126daa0c9f24f9c79f09e07e"} Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Ian Lance Taylor: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Ian Lance Taylor: Patch Set 5: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-26T03:49:45Z","revision":"b1254df4909bff17126daa0c9f24f9c79f09e07e"} Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Ian Lance Taylor: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 5: This CL has failed the run. Reason: Tryjob golang/try/x_sys-gotip-netbsd-arm64 has failed with summary (view all results): Task did not start, no resource Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Ian Lance Taylor: Patch Set 6: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Ian Lance Taylor: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 6: Failed to compute tryjob requirement. Reason: builder "golang/try/x_sys-gotip-netbsd-amd64" is included but not defined in the LUCI project Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Ian Lance Taylor: Patch Set 6: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Ian Lance Taylor: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 6: Failed to compute tryjob requirement. Reason: builder "golang/try/x_sys-gotip-netbsd-amd64" is included but not defined in the LUCI project Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Ian Lance Taylor: Patch Set 7: Commit message was updated. Copied Votes:
Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Ian Lance Taylor: Patch Set 7: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-06-26T13:48:18Z","revision":"02c1a4f11cb6a27067ce0aeb5f19d0cb1750f411"} Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Ian Lance Taylor: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
Message from Joedian Reid: Patch Set 8: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/594756. |
NetBSD apparently doesn't allow remapping into used address space. This means that the test that uses mremap to move a mmapped page into a new address should first mmap (to reserve) then munmap (to free) the destination. Fixes golang/go#68180 Change-Id: If66b67e7166ca4dc4331a8cfc3e3a285416e9849 GitHub-Last-Rev: 92058c2 GitHub-Pull-Request: #198 Cq-Include-Trybots: luci.golang.try:x_sys-gotip-netbsd-amd64 Reviewed-on: https://go-review.googlesource.com/c/sys/+/594756 Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Joedian Reid <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
This PR is being closed because golang.org/cl/594756 has been merged. |
NetBSD apparently doesn't allow remapping into used address space.
This means that the test that uses mremap to move a mmapped page
into a new address should first mmap (to reserve)
then munmap (to free) the destination.
Fixes golang/go#68180
Cq-Include-Trybots: luci.golang.try:x_sys-gotip-netbsd-amd64