Revert "go/packages: temporarily disable some tests running on go tip…

… with -race" This reverts CL 200819. Reason for revert: known races in dependencies have been fixed. Change-Id: I7019055ea57b846d7546fbcc628fb341b7351a99 Reviewed-on: https://go-review.googlesource.com/c/tools/+/202538 Run-TryBot: Bryan C. Mills <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
golang · Oct 28, 2019 · 8715e36 · 8715e36
1 parent b2104f8
commit 8715e36
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 68 deletions.
diff --git a/go/analysis/multichecker/multichecker_race_test.go b/go/analysis/multichecker/multichecker_race_test.go
diff --git a/go/analysis/multichecker/multichecker_test.go b/go/analysis/multichecker/multichecker_test.go
@@ -7,7 +7,6 @@ import (
 	"os"
 	"os/exec"
 	"runtime"
-	"strings"
 	"testing"
 
 	"golang.org/x/tools/go/analysis"
@@ -30,15 +29,9 @@ func main() {
 	multichecker.Main(findcall.Analyzer, fail)
 }
 
-var race = false
-
 // TestExitCode ensures that analysis failures are reported correctly.
 // This test fork/execs the main function above.
 func TestExitCode(t *testing.T) {
-	if v := runtime.Version(); strings.Contains(v, "devel") && race {
-		t.Skip("golang.org/issue/31749: This test is broken on tip in race mode. Skip until it's fixed.")
-	}
-
 	if runtime.GOOS != "linux" {
 		t.Skipf("skipping fork/exec test on this platform")
 	}

diff --git a/go/loader/loader_race_test.go b/go/loader/loader_race_test.go
diff --git a/go/loader/loader_test.go b/go/loader/loader_test.go
@@ -262,13 +262,7 @@ func TestLoad_FromSource_Success(t *testing.T) {
 	}
 }
 
-var race = false
-
 func TestLoad_FromImports_Success(t *testing.T) {
-	if v := runtime.Version(); strings.Contains(v, "devel") && race {
-		t.Skip("golang.org/issue/31749: This test is broken on tip in race mode. Skip until it's fixed.")
-	}
-
 	if runtime.Compiler == "gccgo" {
 		t.Skip("gccgo has no standard library test files")
 	}

diff --git a/go/packages/packages_race_test.go b/go/packages/packages_race_test.go
diff --git a/go/packages/packages_test.go b/go/packages/packages_test.go
@@ -2342,14 +2342,8 @@ const A = 4
 	}
 }
 
-var race = false
-
 func TestIssue32814(t *testing.T) { packagestest.TestAll(t, testIssue32814) }
 func testIssue32814(t *testing.T, exporter packagestest.Exporter) {
-	if v := runtime.Version(); strings.Contains(v, "devel") && race {
-		t.Skip("golang.org/issue/31749: This test is broken on tip in race mode. Skip until it's fixed.")
-	}
-
 	exported := packagestest.Export(t, exporter, []packagestest.Module{{
 		Name:  "golang.org/fake",
 		Files: map[string]interface{}{}}})

diff --git a/go/packages/stdlib_test.go b/go/packages/stdlib_test.go
@@ -19,10 +19,6 @@ import (
 
 // This test loads the metadata for the standard library,
 func TestStdlibMetadata(t *testing.T) {
-	if v := runtime.Version(); strings.Contains(v, "devel") && race {
-		t.Skip("golang.org/issue/31749: This test is broken on tip in race mode. Skip until it's fixed.")
-	}
-
 	// TODO(adonovan): see if we can get away without this hack.
 	// if runtime.GOOS == "android" {
 	// 	t.Skipf("incomplete std lib on %s", runtime.GOOS)