Add "inamedparam": checks for interface method with unnamed params (#…

…3793)

Co-authored-by: Fernandez Ludovic <[email protected]>

.golangci.reference.yml

@@ -2263,6 +2263,7 @@ linters:
     - grouper
     - ifshort
     - importas
+    - inamedparam
     - ineffassign
     - interfacebloat
     - interfacer
@@ -2380,6 +2381,7 @@ linters:
     - grouper
     - ifshort
     - importas
+    - inamedparam
     - ineffassign
     - interfacebloat
     - interfacer

go.mod

@@ -67,6 +67,7 @@ require (
 	github.com/ldez/tagliatelle v0.5.0
 	github.com/leonklingele/grouper v1.1.1
 	github.com/lufeee/execinquery v1.2.1
+	github.com/macabu/inamedparam v0.1.2
 	github.com/maratori/testableexamples v1.0.0
 	github.com/maratori/testpackage v1.1.1
 	github.com/matoous/godox v0.0.0-20230222163458-006bad1f9d26

pkg/golinters/inamedparam.go

@@ -0,0 +1,19 @@
+package golinters
+
+import (
+	"github.com/macabu/inamedparam"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewINamedParam() *goanalysis.Linter {
+	a := inamedparam.Analyzer
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeSyntax)
+}

pkg/lint/lintersdb/manager.go

@@ -578,6 +578,11 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithLoadForGoAnalysis().
 			WithURL("https://github.com/julz/importas"),
 
+		linter.NewConfig(golinters.NewINamedParam()).
+			WithSince("v1.55.0").
+			WithPresets(linter.PresetStyle).
+			WithURL("https://github.com/macabu/inamedparam"),
+
 		linter.NewConfig(golinters.NewIneffassign()).
 			WithEnabledByDefault().
 			WithSince("v1.0.0").

test/testdata/inamedparam.go

@@ -0,0 +1,29 @@
+//golangcitest:args -Einamedparam
+package testdata
+
+import "context"
+
+type tStruct struct {
+	a int
+}
+
+type Doer interface {
+	Do() string
+}
+
+type NamedParam interface {
+	Void()
+
+	NoArgs() string
+
+	WithName(ctx context.Context, number int, toggle bool, tStruct *tStruct, doer Doer) (bool, error)
+
+	WithoutName(
+		context.Context, // want "interface method WithoutName must have named param for type context.Context"
+		int, // want "interface method WithoutName must have named param for type int"
+		bool, // want "interface method WithoutName must have named param for type bool"
+		tStruct, // want "interface method WithoutName must have named param for type tStruct"
+		Doer, // want "interface method WithoutName must have named param for type Doer"
+		struct{ b bool }, // want "interface method WithoutName must have all named params"
+	)
+}