-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to install using script from goreleaser.com #575
Comments
golangci/golangci-lint#575 Avoid the above problems.
The version on goreleaser is broken, and it is unclear why: golangci/golangci-lint#575 – use the direct Github URL as a workaround. Signed-off-by: Matthias Rampke <[email protected]>
A temporary work-around, to get your CI pipline working again immediately, is to update your install command:
Note the addition of the |
While this does the trick, I wonder if a different approach is better. I noticed that the To avoid these things, and actually use a static version of the script for reproducible builds, I changed the URL to simply point to a specific tag in this repo. i.e What do you think? I'd appreciate one of the maintainers to confirm this is a valid approach, just to make sure I can rely on this tag to be frozen and contain all the necessary installation features as the script in |
@iliapolo I like this approach. |
The version on goreleaser is broken and different from the one in Github: golangci/golangci-lint#575 – use the direct Github URL as a workaround. Additionally, the installer script attempts to `install -d /go/bin` on CircleCI, which doesn't work due to permissions. Patch that line out – we don't need it because we make sure the directory exists anyway. Signed-off-by: Matthias Rampke <[email protected]>
@iliapolo I'm not the one to comment on your proposal. I offered a simple, temporary workaround. Emphasis on temporary and workaround. I leave it to the project maintainers to come up with a better permanent solution. |
@flimzy I know, didn't mean to imply otherwise. Still waiting on one of the maintainers to reply. |
FYI this is fixed from goreleaser |
Just checked, the issue is fixed, as @LarsOL said:
|
as golangci/golangci-lint#575 is fixed now.removing the workaround in CI Signed-off-by: Madhu Rajanna <[email protected]>
as golangci/golangci-lint#575 is fixed now.removing the workaround in CI Signed-off-by: Madhu Rajanna <[email protected]>
as golangci/golangci-lint#575 is fixed now.removing the workaround in CI Signed-off-by: Madhu Rajanna <[email protected]>
as golangci/golangci-lint#575 is fixed now.removing the workaround in CI Signed-off-by: Madhu Rajanna <[email protected]>
as golangci/golangci-lint#575 is fixed now.removing the workaround in CI Signed-off-by: Madhu Rajanna <[email protected]>
as golangci/golangci-lint#575 is fixed now.removing the workaround in CI Signed-off-by: Madhu Rajanna <[email protected]>
The current recommended installation steps use githubusercontent.com instead of goreleaser.com. There has been a reported issue in which the installer code differed between the two sites. golangci/golangci-lint#575 Additionally, pin to a specific tagged version of the install script to ensure reproducible installations of the tool. Use version 1.19.1. The latest two releases (1.21.0, 1.20.0) have a flaky bug (at least on macOS) that prevents the linter to run while still exiting with code 0 (success). ``` ~/s/sentry-go ❯❯❯ golangci-lint run WARN [runner] Can't run linter goanalysis_metalinter: assign: failed prerequisites: [email protected]/getsentry/sentry-go/echo ~/s/sentry-go ❯❯❯ golangci-lint run WARN [runner] Can't run linter goanalysis_metalinter: interfacer: failed prerequisites: [email protected]/getsentry/sentry-go/echo ``` See - golangci/golangci-lint#866 - golangci/golangci-lint#827
The current recommended installation steps use githubusercontent.com instead of goreleaser.com. There has been a reported issue in which the installer code differed between the two sites. golangci/golangci-lint#575 Additionally, pin to a specific tagged version of the install script to ensure reproducible installations of the tool. Use version 1.19.1. The latest two releases (1.21.0, 1.20.0) have a flaky bug (at least on macOS) that prevents the linter to run while still exiting with code 0 (success). ``` ~/s/sentry-go ❯❯❯ golangci-lint run WARN [runner] Can't run linter goanalysis_metalinter: assign: failed prerequisites: [email protected]/getsentry/sentry-go/echo ~/s/sentry-go ❯❯❯ golangci-lint run WARN [runner] Can't run linter goanalysis_metalinter: interfacer: failed prerequisites: [email protected]/getsentry/sentry-go/echo ``` See - golangci/golangci-lint#866 - golangci/golangci-lint#827
The current recommended installation steps use githubusercontent.com instead of goreleaser.com. There has been a reported issue in which the installer code differed between the two sites. golangci/golangci-lint#575 Additionally, pin to a specific tagged version of the install script to ensure reproducible installations of the tool. Use version 1.19.1. The latest two releases (1.21.0, 1.20.0) have a flaky bug (at least on macOS) that prevents the linter to run while still exiting with code 0 (success). ``` ~/s/sentry-go ❯❯❯ golangci-lint run WARN [runner] Can't run linter goanalysis_metalinter: assign: failed prerequisites: [email protected]/getsentry/sentry-go/echo ~/s/sentry-go ❯❯❯ golangci-lint run WARN [runner] Can't run linter goanalysis_metalinter: interfacer: failed prerequisites: [email protected]/getsentry/sentry-go/echo ``` See - golangci/golangci-lint#866 - golangci/golangci-lint#827
Installing
golangci-lint
using script from goreleaser.com, failed:While using fallback script, it works fine:
The text was updated successfully, but these errors were encountered: