Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comparison to gometalinter in benchmarks #1732

Merged
merged 12 commits into from
Feb 21, 2021
Merged

Remove comparison to gometalinter in benchmarks #1732

merged 12 commits into from
Feb 21, 2021

Conversation

pkuca
Copy link
Contributor

@pkuca pkuca commented Feb 13, 2021 •
edited
Loading

  • Remove gometalinter run from bench test
  • Clone remote tool repo to local repository in bench test

@ldez
Copy link
Member

ldez commented Feb 14, 2021 •
edited
Loading

As it's a breaking change, we cannot remove the linter like that.

#541 (comment)

@ldez ldez added the blocked Need's direct action from maintainer label Feb 14, 2021
@SVilgelm
Copy link
Member

so, it's archived, but the lates code a completely compatible with golangci-lint, personally I never seen any suggestions from this linter, but it's enabled.
Instead of removing the linter, let's mark it as deprecated and printing a warning message.

@pkuca
Copy link
Contributor Author

pkuca commented Feb 17, 2021

"mark it as deprecated and printing a warning message" - what's the recommended way to do both of those things? I may have missed other occurrences while searching.

@ernado
Copy link
Member

ernado commented Feb 17, 2021

I'm not sure that we done such thing before, so there can be no examples.

@SVilgelm
Copy link
Member

@pkuca @ernado please see the #1755 PR, I added a feature to mark the linters as deprecated.

@SVilgelm
Copy link
Member

@pkuca The PR #1755 is merged, so we marked the interfacer as deprecated. Please rebase this PR, but don't delete interfacer

@pkuca pkuca changed the title Remove interfacer Remove comparison to gometalinter in benchmarks Feb 21, 2021
@ldez ldez added topic: cleanup Related to code, process, or doc cleanup and removed blocked Need's direct action from maintainer labels Feb 21, 2021
ldez
ldez approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit a3c2ed0 into golangci:master Feb 21, 2021
@pkuca pkuca deleted the remove-interfacer branch February 21, 2021 19:34
@ldez ldez added this to the v1.38 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.38
Development

Successfully merging this pull request may close these issues.
4 participants
@pkuca @ldez @SVilgelm @ernado