Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and assets #1828

Closed

Conversation

golangci-releaser
Copy link
Collaborator

Automated changes by create-pull-request GitHub action

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 9, 2021

Hey, thank you for opening your first Pull Request !

@ldez ldez added the blocked Need's direct action from maintainer label Mar 9, 2021
@ldez
Copy link
Member

ldez commented Mar 9, 2021

I don't understand the modification of .github/contributors/package-lock.json

@SVilgelm
Copy link
Member

SVilgelm commented Mar 9, 2021

I don't understand the modification of .github/contributors/package-lock.json

to update the Contributers list, we need to install npm packages (there is a step). It just uses latest node version, so that's why it updated the packages.json
I don't expect other changes in the future

@ldez
Copy link
Member

ldez commented Mar 9, 2021

Ok, thank you for the explanation.

The mac-os env on the CI seems to not be happy today 😢

@SVilgelm
Copy link
Member

SVilgelm commented Mar 9, 2021

@ldez let's close this, no real need in this PR. We will test one more time on next release

@SVilgelm SVilgelm closed this Mar 9, 2021
@SVilgelm SVilgelm deleted the create-pull-request/patch-1615311298 branch March 9, 2021 17:55
@ldez ldez removed the blocked Need's direct action from maintainer label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants