Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intrange to 0.2.0 #4994

Closed
wants to merge 1 commit into from

Conversation

ckaznocha
Copy link
Contributor

@ckaznocha ckaznocha commented Sep 9, 2024

intrange 0.2.0 adds a new check with an autofix and now requires type information. I believe that means some additional changes are needed to golangci-lint beyond the regular dependabot PR.

@ldez
Copy link
Member

ldez commented Sep 9, 2024

Closed in favor of #4996

@ldez ldez closed this Sep 9, 2024
@ldez ldez added the declined label Sep 9, 2024
@ckaznocha
Copy link
Contributor Author

@ldez it doesn't look like the other PR included the autofix config. Are additional changes needed to set that up properly?

@ldez
Copy link
Member

ldez commented Sep 9, 2024

because the autofix is not what you think: it's not related to SuggestedFixes but to something specific inside golangci-lint that linter should implement.

An example can be found here: https://github.com/4meepo/tagalign/blob/e25313ba1e10f624375cf2573cdcf07473178606/tagalign.go#L163-L173

@bombsimon
Copy link
Member

bombsimon commented Sep 9, 2024

You can follow #1779 for SuggestedFixes support

@ckaznocha
Copy link
Contributor Author

Got it, thanks for the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants