Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoldenEye Multiplayer - 3&4 player not rendering #1173

Closed
loganmc10 opened this issue Oct 13, 2016 · 24 comments
Closed

GoldenEye Multiplayer - 3&4 player not rendering #1173

loganmc10 opened this issue Oct 13, 2016 · 24 comments

Comments

@loganmc10
Copy link
Contributor

image

I'm not sure how long this issue has existed for.

@loganmc10
Copy link
Contributor Author

Does anyone have any ideas about this? It seems like it's probably been around for at least a couple months. I don't see any GL errors being generated.

2 player mode also has the issue (the player on the bottom isn't visible)

@AmbientMalice
Copy link
Contributor

I think the bug has been around since the start.

@loganmc10
Copy link
Contributor Author

Disabling Framebuffer Emulation fixes the problem

@AmbientMalice
Copy link
Contributor

Well, it could be forced disabled, but it's really not ideal.

@loganmc10
Copy link
Contributor Author

No it shouldn't be disabled, I mentioned that just as a hint as to where the problem probably lies

@loganmc10
Copy link
Contributor Author

I've been troubleshooting another issue (the depth issues in the Raspberry Pi and some Android phones) and I added a glClear(GL_DEPTH_BUFFER_BIT) after each glBindFramebuffer() call, and it almost fixes this problem.

The bottoms players now show up, but it "flickers" every 3 seconds or so with the improper image. There is something up with depth buffer clearing....

@Blue-Ike
Copy link

This issue seems kind of related to #836.

@LuismaSP89
Copy link

Yes, this is a really annoying problem, the players can move around the scenario and the other players can see them, but it´s like the player 3 and 4 where playing at blind man's bluff game.

@Exequiel3k
Copy link

I noticed by disabling "EnableFragmentDepthWrite" & "EnableFBEmulation", it fixes the 4 screens multiplayer issue.

With all that in mind, I tried to automate it via m64p custom.ini but the "FragmentDepthWrite" isn't being disabled which causes constant flickering/misalignment..
This is how I wrote it:

[GOLDENEYE]
Good_Name=007 - GoldenEye (E)(U)
FragmentDepthWrite\enable=0
FrameBufferEmulation\enable=0
N64DepthCompare\enable=1

Does it have to be written in a different way??

@loganmc10
Copy link
Contributor Author

The options should look like:

frameBufferEmulation\N64DepthCompare=1
frameBufferEmulation\enable=0
generalEmulation\enableFragmentDepthWrite=0

I don't think N64 Depth Compare is going to do anything if you have Framebuffer emulation disabled

Also, unfortunately I must have missed enableFragmentDepthWrite when I implemented ini reading for mupen64plus, it's missing. I'll have to submit a PR to add it before it'll be able to read that from the ini file

@Exequiel3k
Copy link

Alright, thanks for the update👍

@Exequiel3k
Copy link

Exequiel3k commented Oct 28, 2017

On a side note, if it's doable, is it possible to add NativeResTexrects as well in the ini reading?

@loganmc10
Copy link
Contributor Author

That's already in there as generalEmulation\enableNativeResTexrects

You can see what is currently read in https://github.com/gonetz/GLideN64/blob/master/src/mupenplus/Config_mupenplus.cpp by looking at the Config_LoadCustomConfig() function

@Exequiel3k
Copy link

Thx for the info, I was wondering what was being read or not :p

@williansti
Copy link

this problem remains unsolved? here is the same problem, impossible to play 007 gondeneye for 4 with this plugin

@Exequiel3k
Copy link

if you're using m64p (the latest version), paste this into the custom.ini file:

[GOLDENEYE]
Good_Name=007 - GoldenEye (E)(U)
frameBufferEmulation\enable=0
generalEmulation\enableFragmentDepthWrite=0

Solved my problem for goldeneye 4 player..

@loganmc10
Copy link
Contributor Author

The same thing should work in Project64

@williansti
Copy link

williansti commented Nov 3, 2017

I am using updated project64, the tip custom.ini does not work adding it to screens 1 and 2 flashes, screens 3 and 4 remain defective.

Project64 Git 2017/10/25
GLideN64 2017/10/29

without the fix
without the fix

with the fix
with the fix

@Exequiel3k
Copy link

Exequiel3k commented Nov 3, 2017

The code is based on using latest version of m64p..

@fzurita
Copy link
Contributor

fzurita commented Nov 3, 2017

To me this seems like a problem with depth on the LLE triangles used to draw the sky.

@Exequiel3k
Copy link

Just a little heads up, I recently updated the build and noticed the quick fix isn’t working anymore. I can no longer play 4 split screen since it’s either flashing and/or only the sky is visible on the bottom screens. Just thought I’d let you’ll know..

@LuismaSP89
Copy link

@gonetz Is not in this thread/post, let´s hope he see and solve this problem.

@truskj
Copy link

truskj commented Feb 17, 2018

I play a lot of GoldenEyeX, a mod for perfect dark, it suffers from the same problem.
but I found that having the screen split set to vertical instead of horizontal, this will remedy the problem.
even if you are playing in four player mode, the setting still makes a difference.
People playing GE are out of luck, but I imagine the same thing will work in Perfect Dark.

gonetz added a commit that referenced this issue Sep 23, 2018
…or it.

Fixed GoldenEye Multiplayer - 3&4 player not rendering #1173
gonetz added a commit that referenced this issue Sep 24, 2018
…or it.

Fixed GoldenEye Multiplayer - 3&4 player not rendering #1173
gonetz added a commit that referenced this issue Sep 25, 2018
…or it.

Fixed GoldenEye Multiplayer - 3&4 player not rendering #1173
gonetz added a commit that referenced this issue Sep 30, 2018
…or it.

Fixed GoldenEye Multiplayer - 3&4 player not rendering #1173
@Blue-Ike
Copy link

Blue-Ike commented Oct 2, 2018

The latest WIP (Master + FB Fixes) addressed and fixed these issues on Goldeneye and on Perfect Dark as well. Multiplayer screens for both 3rd and 4th player are now rendered and are playable. #836 was closed by me since that's no longer an issue either. Therefore, this can also be closed.

@gonetz gonetz closed this as completed Oct 2, 2018
gonetz added a commit that referenced this issue Oct 7, 2018
…or it.

Fixed GoldenEye Multiplayer - 3&4 player not rendering #1173
gonetz added a commit that referenced this issue Oct 15, 2018
…or it.

Fixed GoldenEye Multiplayer - 3&4 player not rendering #1173
gonetz added a commit that referenced this issue Oct 16, 2018
…or it.

Fixed GoldenEye Multiplayer - 3&4 player not rendering #1173
gonetz added a commit that referenced this issue Oct 16, 2018
…or it.

Fixed GoldenEye Multiplayer - 3&4 player not rendering #1173
gonetz added a commit that referenced this issue Oct 17, 2018
…or it.

Fixed GoldenEye Multiplayer - 3&4 player not rendering #1173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants