Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preliminary F3DEX3 LVP support #2842

Merged
merged 6 commits into from
Jun 30, 2024
Merged

Conversation

aglab2
Copy link
Contributor

@aglab2 aglab2 commented Jun 7, 2024

This PR provides a preliminary support for F3DEX3. Most of the work done here is chore to make sure F3DEX3 games boot while looking correctly with unaltered F3DEX2 display lists.

@weinerschnitzel
Copy link

weinerschnitzel commented Jun 7, 2024

Can't wait to see sauraen's demos (and future F3DEX3 games) on GLideN64. Thank you so much for doing this!

@ariahiro64
Copy link

dev of the only released romhack with f3dex3 support it works reasonably well.
image

Copy link
Owner

@gonetz gonetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!
I have just a few minor notices.

src/uCodes/F3DEX3.cpp Outdated Show resolved Hide resolved
src/gSP.cpp Outdated Show resolved Hide resolved
src/GBI.cpp Outdated Show resolved Hide resolved
src/GBI.cpp Outdated Show resolved Hide resolved
@gonetz
Copy link
Owner

gonetz commented Jun 30, 2024

dev of the only released romhack with f3dex3 support it works reasonably well.

Where can I get that romhack?

@ariahiro64
Copy link

dev of the only released romhack with f3dex3 support it works reasonably well.

Where can I get that romhack?

an old as version was released for the oot hacking contest in hylian modding but if you want a build that isnt ancient i can dm it in discord. i just dont want to have a incomplete version leaking early (after final i dont care if every single build gets pushed to public)

@ariahiro64
Copy link

dev of the only released romhack with f3dex3 support it works reasonably well.

Where can I get that romhack?

an old as version was released for the oot hacking contest in hylian modding but if you want a build that isnt ancient i can dm it in discord. i just dont want to have a incomplete version leaking early (after final i dont care if every single build gets pushed to public)

i meant i can give you a newer debug build

@aglab2
Copy link
Contributor Author

aglab2 commented Jun 30, 2024

Addressed various issues in commit fc9589b

Copy link
Owner

@gonetz gonetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gonetz gonetz merged commit b36c440 into gonetz:master Jun 30, 2024
10 checks passed
@gonetz
Copy link
Owner

gonetz commented Jun 30, 2024

an old as version was released for the oot hacking contest in hylian modding but if you want a build that isnt ancient i can dm it in discord.

@ariahiro64, I sent you a message in discord.

cheinr pushed a commit to cheinr/GLideN64 that referenced this pull request Sep 8, 2024
* F3DEX3: added initial primitive LVP implementation

* F3DEX3: rework checking for microcode

* F3DEX3: initialize MicrocodeInfo for f3dex3

* F3DEX3: added support for new lights encoding

* F3DEX3: advertise microcode in CMakeFile

* F3DEX3: fixed various nitpicks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants