-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.10 and friends #322
Merged
Merged
3.10 and friends #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
force-pushed
the
we_bein_all_matchy
branch
from
August 23, 2022 10:51
44a0612
to
1eca145
Compare
goodboy
commented
Sep 15, 2022
|
||
|
||
__all__ = [ | ||
'Actor', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exposing purely for type annotations.
goodboy
commented
Sep 15, 2022
tractor/_debug.py
Outdated
@@ -126,7 +126,8 @@ def release(cls): | |||
try: | |||
# sometimes the ``trio`` might already be terminated in | |||
# which case this call will raise. | |||
cls.local_pdb_complete.set() | |||
if cls.local_pdb_complete is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is history from #324 which we can probably land first.
guilledk
approved these changes
Sep 15, 2022
goodboy
force-pushed
the
we_bein_all_matchy
branch
from
September 15, 2022 21:08
4e8b685
to
fd541a6
Compare
Merged
goodboy
force-pushed
the
we_bein_all_matchy
branch
from
September 15, 2022 23:07
fd541a6
to
f07ddf1
Compare
It's been deprecated for a while now and all docs and tests have been changed. Closes #183
goodboy
force-pushed
the
we_bein_all_matchy
branch
from
September 16, 2022 03:41
f07ddf1
to
10eeda2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Official move to strictly supporting python 3.10+ and beginning a "core runtime" internal code rework to look more like
trio
's organization.The main motivation for this change is to begin use of the new
match:
syntax in our internal RPC msg loops 😎high level reorg
._actor.py
->_runtime.py
trio
itself. namely the following routines:Actor._process_messages()
and._async_main()
Landing ToDo:
tractor.run()
once and for all - Removetractor.run()
#183typing.Dict
,Tuple
,List
annotations