Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.10 and friends #322

Merged
merged 11 commits into from
Sep 16, 2022
Merged

3.10 and friends #322

merged 11 commits into from
Sep 16, 2022

Conversation

goodboy
Copy link
Owner

@goodboy goodboy commented Aug 3, 2022

Official move to strictly supporting python 3.10+ and beginning a "core runtime" internal code rework to look more like trio's organization.

The main motivation for this change is to begin use of the new match: syntax in our internal RPC msg loops 😎


high level reorg

  • rename ._actor.py -> _runtime.py
  • move a bunch of rather large singleton-task-executed runtime methods to be module level functions to look more like the internals of trio itself. namely the following routines:
    • Actor._process_messages() and ._async_main()

Landing ToDo:

@goodboy goodboy force-pushed the we_bein_all_matchy branch from 44a0612 to 1eca145 Compare August 23, 2022 10:51
@goodboy goodboy marked this pull request as ready for review September 15, 2022 19:45
@goodboy goodboy requested a review from guilledk September 15, 2022 19:45


__all__ = [
'Actor',
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exposing purely for type annotations.

@@ -126,7 +126,8 @@ def release(cls):
try:
# sometimes the ``trio`` might already be terminated in
# which case this call will raise.
cls.local_pdb_complete.set()
if cls.local_pdb_complete is not None:
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is history from #324 which we can probably land first.

@goodboy goodboy merged commit 368e9f3 into master Sep 16, 2022
@goodboy goodboy deleted the we_bein_all_matchy branch September 16, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants