feat: new ui kit components #5546
Conversation
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/22321/ finished with 'FAILURE' status. |
kandl
force-pushed
the
new-kit-wip
branch
3 times, most recently
from
fcc83b3
to
d2a9d77
Compare
|
extended test - backstop |
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/22414/ finished with 'SUCCESS' status. |
|
extended test - backstop |
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/22425/ finished with 'SUCCESS' status. |
|
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2332/ finished with 'FAILURE' status. |
|
extended test - backstop |
|
extended test - backstop |
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/22432/ finished with 'SUCCESS' status. |
|
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2333/ finished with 'FAILURE' status. |
|
extended test - backstop |
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/22433/ finished with 'SUCCESS' status. |
|
Job gooddata-ui-sdk-pull-request-dispatcher-pipeline at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-pull-request-dispatcher-pipeline/2335/ finished with 'FAILURE' status. |
Add guide to write new components. Add new components to the UI kit: - UiButton - UiIcon Also add screenshot tests for them. Add default theme and theming validation, to avoid growing of the inconsistent default values in the theming variables. Add generation of the default scss theme. Suffix theming variables with inconsistent default values with `-from-theme` suffix, so we can start to use the default theme in scss and still keep theming backward compatible. These variables will be set only if ThemeProvider will set them, so they will be themed the same way as before, but keep fall backing to the default value, even with default theme set. Add experimental ScopedThemeProvider. risk: low
|
extended test - backstop |
|
Job gooddata-ui-sdk-unit-tests at https://checklist.intgdc.com/job/gooddata-ui-sdk/job/gooddata-ui-sdk-unit-tests/22443/ finished with 'SUCCESS' status. |
| Follow these rules: | ||
| - Use prefixes for root elements to avoid class name collisions (e.g., `.gd-ui-kit-button`, `.gd-ui-kit-icon`). | ||
| - Minimize nesting and overrides for better readability and maintainability | ||
| - Avoid using margins for root elements; components should not affect the layout of their parent or sibling elements. |
There was a problem hiding this comment.
"must not" instead of "should not" in this and the next sentence.
|
|
||
| ## Layouting | ||
|
|
||
| Component should care only about its own layout. |
There was a problem hiding this comment.
Must here and the next sentence.
Add guide to write new components.
Add new components to the UI kit:
Also add screenshot tests for them.
Add default theme and theming validation, to avoid growing
of the inconsistent default values in the theming variables.
Add generation of the default scss theme.
Suffix theming variables with inconsistent default values with
-from-themesuffix, so we can start to use the default themein scss and still keep theming backward compatible.
These variables will be set only if ThemeProvider will set them,
so they will be themed the same way as before, but keep
fall backing to the default value, even with default theme set.
Add experimental ScopedThemeProvider.
risk: low
JIRA: F1-123
Important
Please, don't forget to run
rush changefor the commits that introduce new features 🙏Refer to documentation to see how to run checks and tests in the pull request. This is the list of the most used commands: