Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HlsSampleSource alternative audios #1784

Closed
Duna opened this issue Aug 29, 2016 · 1 comment
Closed

HlsSampleSource alternative audios #1784

Duna opened this issue Aug 29, 2016 · 1 comment
Assignees
@AquilesCanta
Labels
bug

Comments

@Duna
Copy link

Duna commented Aug 29, 2016

HlsSampleSource alternative audios have the same language as the primary muxed audio even in the manifest it is different one
Issue comes from HlsSampleSource.java line 568 at buildTracks(HlsExtractorWrapper extractor)

The correct code is:

else {
        extractorTrackIndices[trackIndex] = i;
        chunkSourceTrackIndices[trackIndex] = -1;
        **trackFormats[trackIndex++] = format.copyWithLanguage(format.language == null ? language : format.language);**
      }
@AquilesCanta
Copy link
Contributor

This will be fixed in version 1 as well in the next push.

ojw28 pushed a commit that referenced this issue Aug 31, 2016
@AquilesCanta @ojw28
Correct language propagation
4d92d8f 
Issue: #1784

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=131811458
@ojw28 ojw28 closed this as completed Sep 13, 2016
@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AquilesCanta AquilesCanta

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Duna @ojw28 @AquilesCanta