-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CEA-608 embedded in video representations in DASH #2362
Comments
Hi ojw28, As you marked it as enhancement , the updated version of Exo-Player will support embedded CEA-608 captions of video in Dash Streaming ? According to Dash-IF-IOP document, we use to signal the CEA-608 in manifest file as follows
Will it display CC by using updated version of Exo-Player ? |
That's the intention, yes. We're not promising to add support, but it's something we're actively looking at. This issue will be used to track any work in this area. If we do add support, it's likely that we will require the Accessibility element to be present in the AdaptationSet for CEA-608 to be enabled. It sounds like you're already adding it. It would be preferable, although likely not required, if you could also fill out the |
Specifically, the most useful thing for the client would be if you used values of the form:
|
Issue: #2362 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=145401668
Issue: #2362 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=145402640
- Fix to use different track ids for EMSG + CEA608, so they can both be enabled at once. - Tweaked extractor to output formats prior to endTracks() when parsing the initial moov box. This makes it easier to handle multiple tracks through the chunk package. It may or may not be made a requirement (it's already true for the MKV extractor). Issue: #2362 Issue: #2176 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=145538757
Issue: #2362 Issue: #2176 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=146243681
Issue: #2362 Issue: #2176 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=148216614
This change exposes declared CEA-608 and EMSG tracks. The tracks currently provide no samples. Issue: #2362 Issue: #2176 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=148390849
Issue: #2362 Issue: #2176 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=148764237
Issue: #2362 Issue: #2176 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=149524412
I think it's likely we'll revert back to discarding media in sync with the playback position for ExtractorMediaSource and HlsMediaSource too, where the tracks are muxed with ones we're requesting anyway. Note: discardBuffer is named as it is because it'll also be used to discard for enabled tracks soon, as a result of the remaining TODO in ChunkSampleStream. For enabled tracks the discard will also be conditional on the samples having been consumed, obviously. Issue: #2362 Issue: #2176 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=149525857
This functionality should be working now in There's still one technical issue where events might go missing when seeking short distances and/or toggling the cea-608 tracks on and off, so the issue is kept open to track fixing that. It's unlikely to be much of an issue in practice, however. |
Ok! I will give a try and let you know . Thanks |
Marking as fixed. We'll track the remaining minor issue separately. |
As per title.
The text was updated successfully, but these errors were encountered: