Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLS - Provide easy way to access current bitrate #3297

Closed
davibe opened this issue Sep 26, 2017 · 11 comments
Closed

HLS - Provide easy way to access current bitrate #3297

davibe opened this issue Sep 26, 2017 · 11 comments
Assignees
@ojw28
Labels
enhancement

Comments

@davibe
Copy link
Contributor

davibe commented Sep 26, 2017

What's the correct way to get the "current bitrate" of the video track been played ? I understand one may refer to the hls/dash bitrate written in the playlist or the actual bitrate shown by the renderer. I am interested in both. I am using v2 and issues like #646 and #3006 are not helping much on this front.
@soadri
Copy link

soadri commented Sep 26, 2017 •
edited
Loading

player.getVideoFormat().bitrate

may be in the playlist

@davibe
Copy link
Contributor Author

davibe commented Sep 28, 2017 •
edited
Loading

@soadri as mentioned in #3006 that's for internal usage only and I always read -1in my cases (mostly hls)

@ojw28
Copy link
Contributor

ojw28 commented Oct 2, 2017

@AquilesCanta - Do you think we could/should push the bitrate into the video formats that are consumed by the video renderer (or the audio formats, in the case of audio only streams)? It's probably going to remove some confusion here.

@ojw28 ojw28 changed the title How to get current video bitrate HLS - Provide easy way to access current bitrate Oct 2, 2017
@AquilesCanta
Copy link
Contributor

Sorry, hadn't seen this. Will look into it.

@ojw28 ojw28 removed the question label Nov 19, 2017
@seiji-fli
Copy link

any progress on this? could really use this for analytics

@AkivaGit

This comment has been minimized.

Sign in to view
@ojw28 ojw28 assigned ojw28 and unassigned AquilesCanta Jul 13, 2018
@ojw28
Copy link
Contributor

ojw28 commented Jul 13, 2018

I can propagate the bit-rate through as part of a related change.

@AkivaGit

This comment has been minimized.

Sign in to view
@ojw28 ojw28 mentioned this issue Jul 17, 2018
Closed
@AkivaGit

This comment has been minimized.

Sign in to view
@ojw28

This comment has been minimized.

Sign in to view
ojw28 added a commit that referenced this issue Jul 17, 2018
@ojw28
HLS: Fill primary sample formats with track format info (e.g. bitrate)
b25a124 
Issue: #3297

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=204732266
@ojw28
Copy link
Contributor

ojw28 commented Jul 17, 2018

Bit-rate should be propagated in dev-v2 now.

@ojw28 ojw28 closed this as completed Jul 17, 2018
@google google locked and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ojw28 ojw28

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@davibe @seiji-fli @ojw28 @AquilesCanta @soadri @AkivaGit