-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMA Ads: listen to events #3322
Comments
I wonder if we should just provide a getter for the |
Yes, that sounds good. Any solution that allows me to receive the original IMA SKD's events is fine 👍 |
Issue: #3322 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=171508635
When can we expect this to be in release? |
It's in 2.6.0, for which there's current a dev branch. We're still finishing off a few bits and pieces to cherry-pick into it, and expect it to be pushed sometime next week (no promises though). |
Issue description
As a developer I want to be able to respond to certain events. The events of these interfaces are hidden when using the Ima-extension:
AdErrorListener
,AdsLoadedListener
,AdEventListener
I'm currently unable to respond to these events:
A solution would be to allow an external listener to receive these events aswel. i.e.
ImaAdsLoader.addAdEventListener()
andImaAdsLoader.addAdErrorListener()
, ect.Or make an encapsulating listener that transfers all 3 listeners to external code.
Another quicker solution could be to not make the class
final
so I can add the functionality myself.Reproduction steps
None, this is a feature request to open up the SDK
Link to test content
None needed
Version of ExoPlayer being used
r2.5.3
Device(s) and version(s) of Android being used
Any device, but for the sake to name one I'm using the Nexus 6p.
A full bug report captured from the device
See description
The text was updated successfully, but these errors were encountered: