Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI - DefaultTimeBar accessibility issue #4611

Closed
asanChina opened this issue Aug 2, 2018 · 1 comment
Closed

UI - DefaultTimeBar accessibility issue #4611

asanChina opened this issue Aug 2, 2018 · 1 comment
Assignees
@andrewlewis
Labels
bug

Comments

@asanChina
Copy link

DefaultTimeBar has problem with accessibility issue
check the screenshot I got https://photos.app.goo.gl/qMTmTDzyG2M2yL3HA.
I am using app "Accessibility Scanner" (developed by Google, you can download it from play store) to scan the UI element in the screen
@andrewlewis andrewlewis self-assigned this Aug 3, 2018
@andrewlewis andrewlewis added the bug label Aug 3, 2018
@andrewlewis
Copy link
Collaborator

At the moment we're setting the AccessibilityNodeInfo class name to the custom view class name, but it looks like it needs to be the name of the most similar widget from the Android SDK or support library (probably android.widget.SeekBar). See also https://support.google.com/accessibility/android/answer/7661305.

ojw28 pushed a commit that referenced this issue Aug 6, 2018
@andrewlewis @ojw28
Fix DefaultTimeBar accessibility class name
b3b8356 
See https://support.google.com/accessibility/android/answer/7661305.

Also fix/suppress nullability warnings.

Issue: #4611

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=207245115
@ojw28 ojw28 closed this as completed Aug 6, 2018
ojw28 pushed a commit that referenced this issue Aug 6, 2018
@andrewlewis @ojw28
Fix DefaultTimeBar accessibility class name
4cd57e0 
See https://support.google.com/accessibility/android/answer/7661305.

Also fix/suppress nullability warnings.

Issue: #4611

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=207245115
@google google locked and limited conversation to collaborators Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@andrewlewis andrewlewis

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewlewis @asanChina @ojw28