-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redmi Note-4 is under-reporting video playback capabilities #5991
Comments
One more question: Can we achieve this by checking the track codec with the deviceSupported codec types ? Ex:
Then by looping over all the codec counts,
then if codec is supported then shall we decide that the device is capable to play the video/audio ? |
@ojw28 , please suggest. |
I am assuming the track is reported as "NO_EXCEEDS_CAPABILITIES". If that's the case it's possible that the device is under-reporting capabilities. I don't think we work around these issues on the ExoPlayer side. You can implement a custom Track Selector that does overrides this selection for you. You can also contact the device manufacturer about this issue. Any input on this @ojw28? |
Without proper, complete and precise reproduction steps, there's nothing we can do to efficiently look at this issue. Please provide some. |
Steps to reproduce: Steps:
Replace: with this,
4096 * 1744, 10.29 Mbps
Result: On Moto G6, it fails with decoder init failed, which is fine because device is not capable enough to play this.
On Redmi Note-4 Snapdragron, it plays this video tracks although |
Relying on Exoplayer for track selection
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* - AndroidX migration - Upgraded gson to 2.8.5 - Upgraded okhttp to 3.14.2 - Upgraded ExoPlayer to 2.10.1 * - API change for 2.10.1 for roleFlag in Subtitles - Refactored MediaPlayerWrapper * - Updated CustomVideoCodecRenderer class. - Keeping the old file for the track. * - Removed CustomVideoCodecRendererOld - Added CustomMediaCodecRenderer * - Decoder re-usability on change media. https://exoplayer.dev/doc/reference/com/google/android/exoplayer2/ExoPlayer.html#setForegroundMode-boolean- * - API Change : Added listener to bandwidth meter. * - clean up * - Restrict max supported bitrate to 5 Gbps - ADAPTIVE support having -1 value is not supported in Exoplayer now, so changed the logic accordingly. * - Issue Resolved: Lowest bitrate tracks was not being added. - Now the isAdaptiveTrack is being analysed based on the flag present in the track. - Removed the restriction of 5Gbps track. Logic is solely dependent on exoplayer now. * - ExtractorMediaSource is deprecated. - Code cleanup * - Removed unused imports * - Reverted track selection code - google/ExoPlayer#5971 * - google/ExoPlayer#5991 Relying on Exoplayer for track selection * - Role Flag was not being used - Version updates for gson and okhttp * @TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR2)
Closing as an obsolete device specific issue. |
Question: On Redmi Note-4,
getTrackSupport
inTrackSelectionView
class does not return the device capability result properly.I added all the tracks available for the following media, then I could see that device is capable enough to play the 10.29 Mbps(4k) media.
Issue:
getTrackSupport
should return the proper device capable tracks. Is there some issue in this method or should i use any other method to get the results correct.The text was updated successfully, but these errors were encountered: