Midroll ads freeze frame after playing #6009
Assignees
Labels
Comments
|
I can reproduce a slightly different problem using the same reproduction steps, but I think they both have the same underlying reason. Under the given setup, we end up with negative renderer timestamps and not all platform decoders handle negative timestamps well. In my case, the decoder made rounding errors, changing the frame timestamps by 1 microsecond each, which results in a lot of dropped frames after the seek. I guess the "frozen" frame is a similar problem based on how the Honor View decoder is handling the negative timestamps. |
ojw28
pushed a commit
that referenced
this issue
Jun 18, 2019
We are currently queuing periods in a way such that the new start position lines up with the end of the previous period (to ensure continuous playback). However, if the start position of the new period is larger than the total of all previously played period durations, we may end up with negative renderer timestamps when seeking back to the beginning of this new period. Negative timestamps should be avoided as most decoders have problems handling them correctly. This change forces a renderer reset if we detect such a seek to a negative renderer time and also resets the renderer offset to 0 every time all renderers are disabled, as this is the only time where we can savely change the offset of an existing media period. Also, if playback starts with an ad, we choose the content position as renderer offset to prevent the whole issue from occurring for the seek-behind- midroll case. Issue:#6009 Issue:#5323 PiperOrigin-RevId: 253790054
ojw28
pushed a commit
that referenced
this issue
Jun 19, 2019
We are currently queuing periods in a way such that the new start position lines up with the end of the previous period (to ensure continuous playback). However, if the start position of the new period is larger than the total of all previously played period durations, we may end up with negative renderer timestamps when seeking back to the beginning of this new period. Negative timestamps should be avoided as most decoders have problems handling them correctly. This change forces a renderer reset if we detect such a seek to a negative renderer time and also resets the renderer offset to 0 every time all renderers are disabled, as this is the only time where we can savely change the offset of an existing media period. Also, if playback starts with an ad, we choose the content position as renderer offset to prevent the whole issue from occurring for the seek-behind- midroll case. Issue:#6009 Issue:#5323 PiperOrigin-RevId: 253790054
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
[REQUIRED] Content description
Play a video with midroll ad,seek beyond the point of midroll ad,then the midroll ad is played and the video playing resumes after ad.If we seek backward the frame freezes.
[REQUIRED] Link to test content
Video Url : http://184.72.239.149/vod/smil:BigBuckBunny.smil/playlist.m3u8
Ads url : https://pubads.g.doubleclick.net/gampad/ads?sz=640x480&iu=/124319096/external/ad_rule_samples&ciu_szs=300x250&ad_rule=1&impl=s&gdfp_req=1&env=vp&output=vmap&unviewed_position_start=1&cust_params=deployment%3Ddevsite%26sample_ar%3Dpremidpost&cmsid=496&vid=short_onecue&correlator=
[REQUIRED] Version of ExoPlayer being used
Version : Exoplayer 2.9.6.I have also checked with the 2.10.0 version.Same issue exists
[REQUIRED] Device(s) and version(s) of Android being used
Honor View 10,API 28
The text was updated successfully, but these errors were encountered: