Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proguard rules for av1 #6773

Closed
master255 opened this issue Dec 17, 2019 · 2 comments
Closed

proguard rules for av1 #6773

master255 opened this issue Dec 17, 2019 · 2 comments
Assignees
Labels

Comments

@master255
Copy link

You need to add proguard rules for new av1 extension:
-keep class com.google.android.exoplayer2.ext.av1.** { *; }

Otherwise, an error occurs:
Error instantiating AV1 extension
Caused by java.lang.NoSuchMethodException
[long, class android.os.Handler, interface c.b.a.a.e1.s, int]...

@ojw28
Copy link
Contributor

ojw28 commented Dec 17, 2019

Could you confirm that it's sufficient to add the following:

-dontnote com.google.android.exoplayer2.ext.av1.Libgav1VideoRenderer
-keepclassmembers class com.google.android.exoplayer2.ext.av1.Libgav1VideoRenderer {
  <init>(long, android.os.Handler, com.google.android.exoplayer2.video.VideoRendererEventListener, int);
}

@master255
Copy link
Author

@ojw28 , Yes Yes. I confirm. Is this the final version of the rules?
Maybe we need to test the playback of AV1? I have not seen such files yet.

ojw28 added a commit that referenced this issue Dec 18, 2019
Issue: #6773
PiperOrigin-RevId: 285990377
@ojw28 ojw28 closed this as completed Dec 18, 2019
ojw28 added a commit that referenced this issue Dec 19, 2019
Issue: #6773
PiperOrigin-RevId: 285990377
@google google locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants