Add default artwork support to SimpleExoPlayerView #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the class level javadoc of SimpleExoPlayerView to include information about the new attribute (around line 67/68). Otherwise this looks great, so we'll get this merged once that's done. Thanks! |
Add support for a default artwork image that is displayed if no artwork can be found in the metadata.
|
@ojw28 I added a description for the new attribute. Should I also update the description of use_artwork to mention that an artwork is also displayed if the default_artwork is set, or is this clear enough? |
|
Looks good, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for a default artwork image that is displayed if no artwork can be found in the metadata.