Skip to content
This repository has been archived by the owner on Aug 10, 2022. It is now read-only.

Add prefers-color-scheme article #7502

Closed
wants to merge 5 commits into from
Closed

Conversation

tomayac
Copy link
Member

@tomayac tomayac commented Apr 12, 2019

  • Add the prefers-color-scheme article

Target Live Date: Draft, do not merge yet!

  • This has been reviewed and approved by (NAME)
  • I have run npm test locally and all tests pass.
  • I have added the appropriate type-something label.
  • I've staged the site and manually verified that my content displays correctly.

@petele
Copy link
Member

petele commented Apr 16, 2019

When this is ready for merging, remove the DO NOT MERGE tag.

@tomayac
Copy link
Member Author

tomayac commented Apr 16, 2019

Sure thing. It’s also one of their new draft PRs, the “do not merge” is implicit.

@petele
Copy link
Member

petele commented Apr 16, 2019

It’s also one of their new draft PRs, the “do not merge” is implicit.

Yah, I saw that, but it doesn't stand out as nicely, when I'm skimming the list of PRs, I can easily skip anything with a big, red DO NOT MERGE label, I have to look for the "Draft" text in small letters.

@tomayac
Copy link
Member Author

tomayac commented May 23, 2019

Closing this PR here in favor of GoogleChrome/web.dev#929, as per a conversation with @robdodson.

@tomayac tomayac closed this May 23, 2019
@petele petele deleted the prefers-color-scheme branch June 4, 2019 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants