fix building docker image #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mco-gh for review |
mco-gh
reviewed
Jul 29, 2021
| @@ -1,10 +1,20 @@ | |||
| FROM golang:1-alpine AS build-env | |||
| FROM golang:1.16 AS build | |||
There was a problem hiding this comment.
why hardcoded vs. alpine or latest? not critizicing, just curious.
There was a problem hiding this comment.
In general, I typically lock in versions where I can. That gives me a chance to test things locally before committing to an upgrade. In this case, go only updates twice a year, so it's not much work to occasionally bump the build version. But of course, it is also probably unnecessarily conservative given the go1 compatibility promise. I don't have strong feelings on it, and am happy to go either way.
There was a problem hiding this comment.
that's fine with me as is, I just wanted to understand the thinking, thanks!
Closed
mco-gh
approved these changes
Jul 29, 2021
This was referenced Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use go modules instead of dep. Use two stage build to build a minimal (4 MB) application image.
Fixes #51 #71 #78