Upgrade to Debian Bullseye and install rsync #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rsync tool can be used to efficiently copy images from an Android build directory into the container by sending only the file differences. rsync needs to be installed on both ends of the transfer. Since super.img and userdata.img are sparse in the build directory it's useful to pass the --sparse --inplace flags so that they end up being sparse in the container as well. Unfortunately there's a bug in older versions of rsync (such as the one in Debian Buster) that causes transfers with these flags to fail. See: RsyncProject/rsync#53 Buster is already obsolete at this point, so let's upgrade to Bullseye which has a fixed version of rsync and install rsync into the container so that it doesn't need to be installed manually.
|
Unfortunately there's still an rsync bug that tends to affect super.img files when passing those two flags: RsyncProject/rsync#450 This is still useful though because --sparse on its own isn't affected, so we can still get the disk space benefits of sparse files on the container end. |
|
Looks like we are trying to bump to bookworm. |
I did |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rsync tool can be used to efficiently copy images from an Android build directory into the container by sending only the file differences. rsync needs to be installed on both ends of the transfer. Since super.img and userdata.img are sparse in the build directory it's useful to pass the --sparse --inplace flags so that they end up being sparse in the container as well. Unfortunately there's a bug in older versions of rsync (such as the one in Debian Buster) that causes transfers with these flags to fail. See: RsyncProject/rsync#53
Buster is already obsolete at this point, so let's upgrade to Bullseye which has a fixed version of rsync and install rsync into the container so that it doesn't need to be installed manually.