Skip to content

Commit

Permalink
Fix implicit conversion changes signess warning in perf_counters.cc (#…
Browse files Browse the repository at this point in the history
…1765)

`read_bytes` is `ssize_t` (and we know it's non-negative),
we need to explicitly cast it to `size_t`.
  • Loading branch information
ivafanas authored Mar 9, 2024
1 parent eaafe69 commit ad7c3ff
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/perf_counters.cc
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ size_t PerfCounterValues::Read(const std::vector<int>& leaders) {
auto read_bytes = ::read(lead, ptr, size);
if (read_bytes >= ssize_t(sizeof(uint64_t))) {
// Actual data bytes are all bytes minus initial padding
std::size_t data_bytes = read_bytes - sizeof(uint64_t);
std::size_t data_bytes =
static_cast<std::size_t>(read_bytes) - sizeof(uint64_t);
// This should be very cheap since it's in hot cache
std::memmove(ptr, ptr + sizeof(uint64_t), data_bytes);
// Increment our counters
Expand Down

0 comments on commit ad7c3ff

Please sign in to comment.