Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Increase minimum required compiler versions #1136

Open
dmah42 opened this issue May 4, 2021 · 1 comment
Open

[RFC] Increase minimum required compiler versions #1136

dmah42 opened this issue May 4, 2021 · 1 comment

Comments

@dmah42
Copy link
Member

dmah42 commented May 4, 2021

Currently, we claim to support g++-4.8 and clang-3.4 as minimum compiler versions (among others). Googletest, on which we depend for testing (but not in general) increased their minimum support to g++-5 and clang-5.

The oldest LTS version of ubuntu we want to support is trusty (14.04) which isn't EOL until April 2022. Out of the box you can get g++-4.8 and clang-3.6.

I noticed this while trying to set up an ubuntu 14.04 CI build

So we have a couple of options:

  1. increase our minimum compiler versions to match googletest.
    • Users on ubuntu 14.04 (or similar older platforms) would need to find sources for newer compiler versions.
    • Tests/CI would continue to run against known good compiler versions
  2. increase our minimum compiler version for benchmark developers to match googletest.
    • This would mean users on ubuntu 14.04 could still use the library.
    • No tests on CI or developer machines would be testing those codepaths beyond building them.

I'd really like to do 2, but i'm not sure of the safety of not having runnable tests and maybe we should just jump straight to 1.

Thoughts?

@dmah42
Copy link
Member Author

dmah42 commented May 17, 2021

So far I've implemented #2 above but not changed the documented policy. Our github actions now build on ubuntu-14.04 vanilla, but run tests on supported compilers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant