Build on MacOs (10.9)

[dcoeurjo]

the project does not compile on MacOs (maverick 10.9).

• cmake output: https://gist.github.com/dcoeurjo/8443412
• the build errors: https://gist.github.com/dcoeurjo/8443487

(as traced in the cmake output, the compiler is Clang 5.0)

[dmah42]

The first error is fixed as of 4e21f5e.

The second error is curious as State is a friend so should be able to access the private member (and can in my non-clang Linux build).

[dcoeurjo]

thanks @dominichamon,

I'm still having bunch of issues (and 4e21f5e fixes the first one I reported): https://gist.github.com/dcoeurjo/8443935

[dmah42]

This is really useful, thank you. I don't have an OSX machine to test on right now.

I just pushed commit c44662e that should help with some (or all) of those errors. Please let me know.

[dcoeurjo]

Few warnings that are reported as "errors" (thanks to -Werror option):

/Users/davidcoeurjolly/local/src/benchmark/src/sysinfo.cc:74:8: error: unused variable 'saw_mhz' [-Werror,-  Wunused-variable]
bool saw_mhz = false;

and

 14%] Building CXX object CMakeFiles/benchmark.dir/src/sysinfo.cc.o
 /Users/davidcoeurjolly/local/src/benchmark/src/sysinfo.cc:47:9: error: unused function 'EstimateCyclesPerSecond' [-Werror,-Wunused-function] 
 int64_t EstimateCyclesPerSecond() {
           ^
 /Users/davidcoeurjolly/local/src/benchmark/src/sysinfo.cc:55:6: error: unused function 'ReadIntFromFile' [-Werror,-Wunused-function]
 bool ReadIntFromFile(const char* file, int* value) {
       ^ 
 2 errors generated.

Beside this warnings, there is no more build errors ;)

[dcoeurjo]

BTW, it'd be better to have the binary and libs compiled in the current cmake build directory rather than in the source tree (bin/, libs/).

I'm running the benchmark_test

[dcoeurjo]

I've run the benchmark test and it's a bit weird: the process uses only 5% of my CPU and does nothing to the std:err.

in this example, I've let it run 16min (wall clock) and then kill it with CTRL-C

time benchmark_test
Reading /proc/self/cputime_ns failed. Using getrusage().
^C
benchmark_test  11,04s user 40,18s system 5% cpu 16:21,84 total

[dmah42]

Commit e2633b9 has the warning(error) fixes.

If you want to submit a patch for cmake i'm happy to take it. The idea is that it should be creating bin and lib in the project root so you have bin, lib, include, src in the project root. Are you seeing something different?

There may be a runtime issue with osx that i don't know about.. it sounds like either one of the clocks isn't ticking or there's a thread issue. I'll try to get an osx test machine going to check it out.

[dcoeurjo]

I'll prepare a pull-request for the cmake stuff.

(And no idea for the OS issue ;))

[dcoeurjo]

I've just updated my working copy and the current release works perfectly on MacOS ! ;)

I'm closing this issue and I've also push a pull-request with some cmake edits (make install).