-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong result of cxx_feature_check depends of CMAKE_CXX_FLAGS in top CMakeList.txt file #50
Comments
I think this means that our test for regex is failing with zero-as-a-null-pointer-constant. Could you attach the CMakeOutput.log and CMakeError.log files please? |
Yes, you are right. It' caused because before launch test for regex
Another question is this expected behaviour or some kind of error. As far as intention of test for regex is realizing of support of regex but not compile piece of code, in my opinion this is some kind of error. I believe that it would be better if in the benchmark project
CMakeError.log:
CMakeOutput.log:
|
We have to compile the code to test for support. We could add the warning and fix the test to compile successfully under that warning too. |
I just tested this and the tests pass with that warning flag enabled, so something else is going on. |
and i reproduced it now.. using g++-4.8. |
adding more details to the cxx feature check:
|
You try to realise this with answer the question: In my opinion this is wrong, and the right way to realise this with answer the question:
I don't have big expirience with |
Fix #50 by using nullptr and adding stricter warning.
I have the Project with structure like this:
My top level
CMakeLists.txt
has following content:My workflow looks like and it works good:
But when I add warning options in the top level
CMakeLists.txt
:I will get error on configuration stage:
The text was updated successfully, but these errors were encountered: