Deflake CI #1751
Merged
Deflake CI #1751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it can be seen in e.g. https://github.com/google/benchmark/actions/runs/7711328637/job/21016492361 We may get `65: BM_Complexity_O1_BigO 0.00 N^2 0.00 N^2 `
LebedevRI
force-pushed
the
deflake-test
branch
from
92eeefa to
cb9bc80
Compare
LebedevRI
force-pushed
the
deflake-test
branch
2 times, most recently
from
bc4de08 to
e9df833
Compare
We were still getting zero times there. Perhaps this is better?
LebedevRI
force-pushed
the
deflake-test
branch
from
e9df833 to
57313a7
Compare
|
@dmah42 green is good right? :) |
dmah42
approved these changes
Feb 2, 2024
| @@ -88,7 +88,7 @@ const char *enum_big_o_1 = "\\([0-9]+\\)"; | |||
| // FIXME: Tolerate both '(1)' and 'lgN' as output when the complexity is auto | |||
| // deduced. | |||
| // See https://github.com/google/benchmark/issues/272 | |||
| const char *auto_big_o_1 = "(\\([0-9]+\\))|(lgN)"; | |||
| const char *auto_big_o_1 = "(\\([0-9]+\\))|(lgN)|(N\\^2)"; | |||
There was a problem hiding this comment.
Hm, i believe the name is still correct.
It is only used for the function where the true/correct complexity is O(1),
we just fail to auto-detect it because of the noise in CI.
There was a problem hiding this comment.
auto_big_o_1_or_lgn_or_n2_actually_we_have_no_idea_what_this_should_be
|
@dmah42 thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as #272
As it can be seen in e.g. https://github.com/google/benchmark/actions/runs/7711328637/job/21016492361
We may get
65: BM_Complexity_O1_BigO 0.00 N^2 0.00 N^2