Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump standard to C++14 #1799

Merged
merged 3 commits into from
Jun 7, 2024
Merged

bump standard to C++14 #1799

merged 3 commits into from
Jun 7, 2024

Conversation

dmah42
Copy link
Member

@dmah42 dmah42 commented Jun 7, 2024

per the dependencies doc, we base our supported standards of the defaults available in compilers or a 10 year expiry from standard release. we just hit 10 years since C++14 release so that's our new base supported standard.

also updated the docs to align on this.

@dmah42 dmah42 mentioned this pull request Jun 7, 2024
@LebedevRI
Copy link
Collaborator

We need to be actually enforcing them via a cmake-time checks though.

@dmah42
Copy link
Member Author

dmah42 commented Jun 7, 2024

We need to be actually enforcing them via a cmake-time checks though.

given we now officially support C++14 for building as a minimum, maybe that's viable. it's hard to enumerate every version of every compiler, which is why the linked support doc focuses on standards and build systems.

@dmah42 dmah42 changed the title update requirements to point to our dependencies doc bump standard to C++14 Jun 7, 2024
Copy link
Collaborator

@LebedevRI LebedevRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings us closer to reality, so looks nice to me.
Thank you!

@dmah42 dmah42 merged commit 10199fb into main Jun 7, 2024
91 of 98 checks passed
@dmah42 dmah42 deleted the update_docs branch June 7, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants