Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump googletest version to match bazel #1868

Merged
merged 2 commits into from
Oct 24, 2024
Merged

bump googletest version to match bazel #1868

merged 2 commits into from
Oct 24, 2024

Conversation

dmah42
Copy link
Member

@dmah42 dmah42 commented Oct 23, 2024

No description provided.

@dmah42
Copy link
Member Author

dmah42 commented Oct 23, 2024

looks like this requires us to bump to cmake 3.13. need to figure out if that's viable.

@dmah42
Copy link
Member Author

dmah42 commented Oct 23, 2024

per https://opensource.google/documentation/policies/cplusplus-support#build-systems: "For example, as of Summer 2024 the oldest supported CMake would be 3.13"

so i guess we're bumping.

@dmah42 dmah42 requested a review from LebedevRI October 23, 2024 10:24
@dmah42 dmah42 merged commit c45d9c4 into main Oct 24, 2024
97 of 98 checks passed
@dmah42 dmah42 deleted the bump_gtest branch October 24, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants