Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update note about linking with pthreads #536

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Conversation

jwakely
Copy link
Contributor

@jwakely jwakely commented Feb 21, 2018

Since GCC 5.1 using std::thread without linking to libpthread causes a linker error, not runtime exceptions. This was changed by https://gcc.gnu.org/PR61841 in 2014, so update the README info.

@jwakely
Copy link
Contributor Author

jwakely commented Feb 21, 2018

IMHO referring to issue #67 here isn't actually very helpful, since that issue contains lots of back and forth trying to identify the problem, when the solution is simply "you need to use -pthread".

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.01% when pulling 8f42cc0 on jwakely:pthreads-note into 858688b on google:master.

@dmah42 dmah42 merged commit e9a49be into google:master Feb 21, 2018
@dmah42
Copy link
Member

dmah42 commented Feb 21, 2018

thank you!

@AppVeyorBot
Copy link

Build benchmark 1085 completed (commit e4cdf9b186 by @jwakely)

@jwakely jwakely deleted the pthreads-note branch February 21, 2018 17:12
EricWF pushed a commit to efcs/benchmark that referenced this pull request Mar 22, 2018
JBakamovic pushed a commit to JBakamovic/benchmark that referenced this pull request Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants