README improvements #648
Merged
README improvements #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricWF
approved these changes
Jul 26, 2018
README.md
Outdated
| When the library is built using GCC it is necessary to link with the pthread | ||
| library due to how GCC implements `std::thread`. Failing to link to pthread will | ||
| lead to runtime exceptions, not linker errors. See [issue #67](https://github.com/google/benchmark/issues/67) | ||
| for more details. You can link to pthread by adding `-lpthread` to your linker |
There was a problem hiding this comment.
I think -pthread is preferable. It's like -lpthread but the compiler puts it in the right place. So you can even put the flag before your object files, and they'll still link.
There was a problem hiding this comment.
will lead to runtime exceptions, not linker errors. See [issue #67]
Hey now! Libc++ has the decency to fail to link!
LebedevRI
approved these changes
Jul 26, 2018
README.md
Outdated
| @@ -123,7 +119,21 @@ Don't forget to inform your linker to add benchmark library e.g. through | |||
| `BENCHMARK_MAIN();` at the end of the source file and link against | |||
| `-lbenchmark_main` to get the same default behavior. | |||
|
|
|||
| The benchmark library will reporting the timing for the code within the `for(...)` loop. | |||
| The benchmark library will reporting the timing for the code within the | |||
There was a problem hiding this comment.
library will reporting the timing
Something is missing between will and reporting.
JBakamovic
pushed a commit
to JBakamovic/benchmark
that referenced
this pull request
Dec 6, 2018
* Clarifications and cleaning of the core documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.