Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to getFastTextWidth #8277

Closed
BeksOmega opened this issue Jul 10, 2024 · 7 comments
Closed

Remove references to getFastTextWidth #8277

BeksOmega opened this issue Jul 10, 2024 · 7 comments
Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

BeksOmega commented Jul 10, 2024 •
edited
Loading

Use getTextWidth instead. getFastTextWidth relies on already knowing about the styling that will be applied to the text, which we can't guarantee now that we're styling with CSS.

To work on this, please comment below asking to be assigned.

This change should be made against the rc/v12.0.0 branch.
@BeksOmega BeksOmega added help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added good first issue labels Jul 10, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 10, 2024
ga-fleury added a commit to ga-fleury/blockly that referenced this issue Jul 11, 2024
@ga-fleury
feat: Remove references to getFastTextWidth (google#8277)
bf4490d
@ga-fleury ga-fleury mentioned this issue Jul 11, 2024
Merged
@BeksOmega
Copy link
Collaborator Author

@ga-fleury is working on this

@AbhinavKRN
Copy link
Contributor

Hey @BeksOmega , i can see no one is assigned on this issue, it would be great if you assign this issue to me?

@BeksOmega
Copy link
Collaborator Author

Heya @AbhinavKRN ga-fleury has a PR up for this at the moment, but if they end up not completing it I'll reassign to you =)

@AbhinavKRN
Copy link
Contributor

@BeksOmega Sure!

@Apocalypse96
Copy link

@BeksOmega I would love to solve this issue

@sachan13harshit
Copy link

@BeksOmega can you pls assign it to me?

BeksOmega pushed a commit that referenced this issue Jul 22, 2024
@ga-fleury
fix: Remove references to getFastTextWidth (#8277) (#8307)
58abf6e 
* feat: Remove references to getFastTextWidth (#8277)

* format
@BeksOmega
Copy link
Collaborator Author

Closed by #8307

@gonfunko gonfunko mentioned this issue Sep 11, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
v12
Development

No branches or pull requests
4 participants
@BeksOmega @AbhinavKRN @sachan13harshit @Apocalypse96