Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename editing CSS class to blocklyEditing #8287

Closed
BeksOmega opened this issue Jul 10, 2024 · 8 comments
Closed

Rename editing CSS class to blocklyEditing #8287

BeksOmega opened this issue Jul 10, 2024 · 8 comments
Assignees
@ga-fleury
Labels
good first issue help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

  1. In the widgetCreate_ method on the FieldInput change the editing string passed to dom.addClass to blocklyEditing.
  2. Also change references to editing in the common renderer CSS and the zelos renderer CSS to blocklyEditing.

This should be merged into the rc/v12.0.0 branch. It should be marked as breaking.

If you want to work on this, comment below to be assigned this issue.
@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong help wanted External contributions actively solicited good first issue labels Jul 10, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 10, 2024
@ga-fleury
Copy link

Hello, I would like to work on this

@BeksOmega
Copy link
Collaborator Author

Go for it @ga-fleury ! Let me know if you have any questions =)

@ga-fleury
Copy link

ga-fleury commented Jul 10, 2024 •
edited
Loading

@BeksOmega opening pull request for this issue

@ga-fleury ga-fleury mentioned this issue Jul 10, 2024
Closed
@BeksOmega
Copy link
Collaborator Author

@BeksOmega I don't think I have permission to push to the rc/v12.0.0 branch

Oh yeah, the correct flow is to use a pull request. You should create a branch off of rc/v12.0.0, make your changes, and then put up a pull request against rc/v12.0.0. See our contributing docs for more info.

@ga-fleury
Copy link

missing CLA, opening new PR

This was referenced Jul 10, 2024
Closed
Closed
Closed
@ga-fleury
Copy link

@BeksOmega I think everything is OK now, took me some time to figure out the correct PR workflow

@ga-fleury ga-fleury mentioned this issue Jul 10, 2024
Closed
1 task
ga-fleury added a commit to ga-fleury/blockly that referenced this issue Jul 11, 2024
@ga-fleury
Rename editing CSS class to blocklyEditing (google#8287)
a6559c9
@ga-fleury ga-fleury mentioned this issue Jul 11, 2024
Merged
ga-fleury added a commit to ga-fleury/blockly that referenced this issue Jul 11, 2024
@ga-fleury
chore!: Rename editing CSS class to blocklyEditing (google#8287)
6b23f74
@ga-fleury
Copy link

@BeksOmega finally got it

BeksOmega pushed a commit that referenced this issue Jul 22, 2024
@ga-fleury
fix!: Rename editing CSS class to blocklyEditing (#8287) (#8301)
e29d7ab 
* chore!: Rename editing CSS class to blocklyEditing (#8287)

* further changes
@BeksOmega
Copy link
Collaborator Author

Closed by #8301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ga-fleury ga-fleury

Labels
good first issue help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
v12
Development

Successfully merging a pull request may close this issue.

chore!: Rename editing CSS class to blocklyEditing
2 participants
@BeksOmega @ga-fleury