Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a blocklyFieldText CSS class to fields' text elements #8291

Closed
BeksOmega opened this issue Jul 10, 2024 · 2 comments · Fixed by #8302
Closed

Add a blocklyFieldText CSS class to fields' text elements #8291

BeksOmega opened this issue Jul 10, 2024 · 2 comments · Fixed by #8302
Assignees
@ga-fleury
Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

In the field's createTextElement_ method, add a blocklyFieldText class to the class property.

blockly/core/field.ts

Line 376 in 8323642

'class': 'blocklyText',

@BeksOmega BeksOmega added help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added good first issue labels Jul 10, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 10, 2024
@ga-fleury
Copy link

Hey @BeksOmega, can you assign this to me?

@ga-fleury ga-fleury mentioned this issue Jul 10, 2024
Closed
ga-fleury added a commit to ga-fleury/blockly that referenced this issue Jul 11, 2024
@ga-fleury
feat!: Add a blocklyFieldText CSS class to fields' text elements (goo…
5bccb69 
…gle#8291)
@ga-fleury ga-fleury mentioned this issue Jul 11, 2024
Merged
@BeksOmega BeksOmega linked a pull request Jul 12, 2024 that will close this issue
feat: Add a blocklyFieldText CSS class to fields' text elements (#8291) #8302
Merged
BeksOmega added a commit that referenced this issue Jul 12, 2024
@ga-fleury @BeksOmega
feat: Add a blocklyFieldText CSS class to fields' text elements (#8291)…
9684942 
… (#8302)

* feat!: Add a blocklyFieldText CSS class to fields' text elements (#8291)

* add class instead of replace

Co-authored-by: Beka Westberg <[email protected]>

---------

Co-authored-by: Beka Westberg <[email protected]>
@BeksOmega
Copy link
Collaborator Author

Closed by #8302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ga-fleury ga-fleury

Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
v12
Development

Successfully merging a pull request may close this issue.

feat: Add a blocklyFieldText CSS class to fields' text elements (#8291) ga-fleury/blockly
2 participants
@BeksOmega @ga-fleury