Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the blocklyTreeIcon CSS class to blocklyToolboxCategoryIcon #8347

Closed
BeksOmega opened this issue Jul 12, 2024 · 4 comments
Closed

Rename the blocklyTreeIcon CSS class to blocklyToolboxCategoryIcon #8347

BeksOmega opened this issue Jul 12, 2024 · 4 comments
Assignees
@krishchvn
Labels
good first issue help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

Rename any references to blocklyTreeIcon to blocklyToolboxCategoryIcon.

This change should be made against the rc/v12.0.0 branch. This should be marked as a breaking change.

To work on this issue, comment below asking to be assigned.
@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong help wanted External contributions actively solicited good first issue labels Jul 12, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 12, 2024
@krishchvn
Copy link

krishchvn commented Jul 14, 2024 •
edited
Loading

Hey. Can you assign the issue to me please?
I've found 2 occurrence(s) of blocklyTreeIcon. Should I change only those 2 or is there something else as well?

@ruthwikchikoti
Copy link

@BeksOmega, please assign this to me. I'm eager to work on it.

@BeksOmega
Copy link
Collaborator Author

Go for it @krishchvn ! I believe you are correct and there are only two instances =)

@krishchvn krishchvn mentioned this issue Jul 15, 2024
Merged
krishchvn added a commit to krishchvn/blockly that referenced this issue Jul 15, 2024
@krishchvn
fix!: renamed blocklyTreeIcon Css class to blocklyToolboxCategoryIcon g…
1c2b3cc 
…oogle#8347
BeksOmega pushed a commit that referenced this issue Jul 17, 2024
@krishchvn
fix!: renamed blocklyTreeIcon Css class to blocklyToolboxCategoryIcon #…
33b5371 
…8347 (#8367)

* renamed blocklyTreeIcon Css class to blocklyToolboxCategoryIcon

* fix!: renamed blocklyTreeIcon Css class to blocklyToolboxCategoryIcon #8347

* fixed whitespace formatting
@BeksOmega
Copy link
Collaborator Author

Closed by #8367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krishchvn krishchvn

Labels
good first issue help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
v12
Development

No branches or pull requests
3 participants
@BeksOmega @krishchvn @ruthwikchikoti