Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group field edits together for undo/redo (attempt #2) #5021

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Group field edits together for undo/redo (attempt #2) #5021

merged 1 commit into from
Jul 12, 2021

Conversation

NeilFraser
Copy link
Contributor

Reverts #4965

@NeilFraser NeilFraser requested a review from cpcallen July 12, 2021 06:21
@NeilFraser NeilFraser requested a review from a team as a code owner July 12, 2021 06:21
@cpcallen
Copy link
Contributor

cpcallen commented Jul 12, 2021 •
edited
Loading

I was wondering why you were reverting, then I saw that the title was

Revert "Revert "Group field edits together for undo/redo"" #5021

@cpcallen cpcallen changed the title Revert "Revert "Group field edits together for undo/redo"" Group field edits together for undo/redo (attempt #2) Jul 12, 2021
cpcallen
cpcallen approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this on the basis that it is identical to previous Group field edits together for undo/redo
#4952

@NeilFraser NeilFraser merged commit b3c94db into develop Jul 12, 2021
@NeilFraser NeilFraser deleted the revert-4965-revert-4952-fraser-bugbash5 branch July 12, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcallen cpcallen cpcallen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeilFraser @cpcallen